Core serializer converts empty object to array on JSON schema which causes empty schemas objects to be incorrectly converted to an array therefore creating issues on pattern's schema.

CommentFileSizeAuthor
#15 patternkit-core-serializer-converts-empty-object-to-array-3275342-15.patch652 bytesbladwin
#9 patternkit-core-serializer-converts-empty-object-to-array-3275342-9.patch3.7 KBbladwin
#4 patternkit-core-serializer-converts-empty-object-to-array-3275342-4.patch3.7 KBbladwin

Issue fork patternkit-3275342

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mariohernandez created an issue. See original summary.

mariohernandez’s picture

mariohernandez commented
Title: Serializer converts empty to object to array » Serializer converts empty object to array
mariohernandez’s picture

mariohernandez commented
Title: Serializer converts empty object to array » Core serializer converts empty object to array
bladwin’s picture

bladwin commented
StatusFileSize
new patternkit-core-serializer-converts-empty-object-to-array-3275342-4.patch3.7 KB

Replaced the two instances of core's serializationInterface from the block plugin and replaced with direct calls to `json_decode`. Additionally, removed the unused serializatoinInterface from the block plugin altogether.

mariohernandez’s picture

mariohernandez commented
Status: Active » Needs review

mariohernandez opened merge request !17

mariohernandez closed merge request !17

mariohernandez opened merge request !18

bladwin’s picture

bladwin commented
StatusFileSize
new patternkit-core-serializer-converts-empty-object-to-array-3275342-9.patch3.7 KB

Adding TRUE to the config reset json_decode call so that empty objects are collapsed into arrays.

mariohernandez credited johnle.

mariohernandez’s picture

mariohernandez commented

mariohernandez credited bfodeke.

mariohernandez’s picture

mariohernandez commented
krisahil’s picture

krisahil commented

I verified this change does not introduce new regressions into my site, though I cannot reproduce the original problem.

bladwin’s picture

bladwin commented
StatusFileSize
new patternkit-core-serializer-converts-empty-object-to-array-3275342-15.patch652 bytes

Conferred with devs and it was decided to add the SerializationInterface back to the code, only replacing the one instance with a direct call to json_decode().

mariohernandez’s picture

mariohernandez commented
Status: Needs review » Fixed
mariohernandez’s picture

mariohernandez commented
Status: Fixed » Closed (fixed)