Problem/Motivation

Reported by @nod_ and @lauriii in #3248425: Ensure that all classes and functions in Drupal-specific CKEditor 5 plugins are documented 👍

There's some crufty conversions happening in core/modules/ckeditor5/js/ckeditor5_plugins/drupalImage/src/imageupload/drupalimageuploadadapter.js.

Proposed resolution

Use response.entity_type in DrupalImageUploadEditing.

Remaining tasks

TBD

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#9 3275237-9-d93.patch36.5 KBlauriii
#9 3275237-9-d95.patch36.5 KBlauriii

Issue fork drupal-3275237

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Wim Leers created an issue. See original summary.

Wim Leers credited lauriii.

Wim Leers credited nod_.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

hooroomoo made their first commit to this issue’s fork.

hooroomoo opened merge request !2223

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Needs work

The merge request looks delightfully simple! 🤩

Looks like this is crashing at least one functional JS test: CKEditor5Test 😅

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs work » Reviewed & tested by the community

Looks ready now! 😄

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
StatusFileSize
new 3275237-9-d95.patch36.5 KB
new 3275237-9-d93.patch36.5 KB

  • lauriii committed b51ab0d on 10.0.x 
    Issue #3275237 by hooroomoo, lauriii, Wim Leers, nod_: Don't convert,...

  • lauriii committed e169a23 on 9.5.x 
    Issue #3275237 by hooroomoo, lauriii, Wim Leers, nod_: Don't convert,...

lauriii closed merge request !2223

  • lauriii committed eb82f6f on 9.4.x 
    Issue #3275237 by hooroomoo, lauriii, Wim Leers, nod_: Don't convert,...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Version: 10.0.x-dev » 9.3.x-dev

Committed b51ab0d and pushed to 10.0.x. Also committed #9 to 9.5.x and cherry-picked to 9.4.x. Thanks!

Leaving open for a 9.3.x commit once the freeze is over.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Fixed

Updating status

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Fixed » Reviewed & tested by the community

Not yet backported 😅

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 9: 3275237-9-d93.patch, failed testing. View results

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs work » Reviewed & tested by the community
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Fixed

Committed f5aced4 and pushed to 9.3.x. Thanks!

  • lauriii committed f5aced4 on 9.3.x 
    Issue #3275237 by hooroomoo, lauriii, Wim Leers, nod_: Don't convert,...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.