Problem/Motivation

File core/themes/olivero/css/base/variable.css is empty (contains only comments) after build command.

Steps to reproduce

cd core
yarn install
yarn build:css

Issue fork drupal-3274598

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

hop created an issue. See original summary.

cilefen’s picture

cilefen commented
Title: build variables.css » The compiled variable.css contains nothing except comments

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

uditrawat’s picture

uditrawat
Primary language English
commented
Version: 9.4.x-dev » 9.5.x-dev

andy-blum made their first commit to this issue’s fork.

andy-blum’s picture

andy-blum
he/him/his
Primary language English
Location Ohio, USA
commented

The file only containing comments is due to the fact that variables are compiled at build time and we can't ship true CSS vars to IE11. The bigger issue is that we probably shouldn't be including this file in the library, but even that's not a big issue as core's aggregation and minification will strip out all comments and empty rulesets. Fix incoming.

andy-blum opened merge request !2774

andy-blum’s picture

andy-blum
he/him/his
Primary language English
Location Ohio, USA
commented
Status: Active » Needs review
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

This is a nice easy solution. We still build the useless file at build time but we don't need to ship it to the browser.

To be clear to committers: this issue only affects 9.4.x and 9.5.x. 10.0.x onwards *do* need to include this file in Olivero as we use CSS variables there.

  • lauriii committed b6bbe7c on 9.5.x 
    Issue #3274598 by andy-blum: The compiled variable.css contains nothing...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Fixed

Committed b6bbe7c and pushed to 9.5.x. Thanks!

lauriii closed merge request !2774

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Issue tags: +Prague2022

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.