PHP warnings during static code analysis using Phan: Expected an object instance when accessing an instance property

Thank you for working on this.

I think it needs a little work.

 function metatag_config_delete_form_submit($form, &$form_state) {
   $config = metatag_config_load($form_state['values']['instance']);
-  metatag_config_delete($config);
+  if (is_object($config)) {
+    metatag_config_delete($config);

This should display an error message of $config is not a valid object.

 function metatag_config_save($config) {
+  if (!is_object($config)) {

How about just adding the "object" declaration in the function definition, i.e. metatag_config_save(object $config)?

 function metatag_config_delete($config) {
+  if (!is_object($config)) {

Ditto.

@@ -1743,14 +1751,16 @@ function metatag_commerce_product_form_submit($form, &$form_state) {
   // The entity being saved.
   $entity_type = 'commerce_product';
   $product = $form_state[$entity_type];
-  $entity_id = $product->product_id;
-  $revision_id = $product->revision_id;
+  if (is_object($product)) {

This needs an error message.

 function metatag_form_alter(&$form, $form_state, $form_id) {
   if (!empty($form['#metatags']) && !isset($form['metatags'])) {
     extract($form['#metatags']);
-    metatag_metatags_form($form, $instance, $metatags, $options);
+    if (isset($metatags) && isset($options)) {
+      metatag_metatags_form($form, $instance, $metatags, $options);
+    }
     unset($form['#metatags']);
   }
 }

This should just not pass the third and fourth arguments, seeing as they don't exist.

+1 RTBC, but someone else to review this one too.

It needs some more work to display error messages, or throwing an exception, when the expected objects aren't loaded, e.g. metatag_config_delete_form_submit().

Added error messages

Hi @loon, Your patch applied cleanly for me. Someone also can review it before moving it to RTBC.

Thanks

@anoopsingh92: FYI posting a screenshot that shows a patch applies is not a useful use of your time, please don't post more of them.

How does this work?

Committed. Thanks everyone.