Problem/Motivation

Currently it's not possible to translate the apply and reset buttons on the block translation page.

Proposed resolution

Update schema file, change button labels from string to label. This allows the fields to appear on the block translation tab.

CommentFileSizeAuthor
#7 facet-form-button-labels-translation-3274513-3.patch551 bytesmariamk
#2 facets-form-button-labels-translation-3274513-2.patch552 bytessmulvih2

Issue fork facets_form-3274513

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

smulvih2 created an issue. See original summary.

smulvih2’s picture

smulvih2
Location Canada 🍁
commented
Status: Active » Needs review
StatusFileSize
new facets-form-button-labels-translation-3274513-2.patch552 bytes

Patch allows the Submit button and Reset button to be translated. Needed to uninstall and reinstall the module to take effect for existing install.

Status: Needs review » Needs work

The last submitted patch, 2: facets-form-button-labels-translation-3274513-2.patch, failed testing. View results

sershevchyk’s picture

sershevchyk
Primary language Ukrainian
Location Lutsk
commented

The last patch works as expected. I think we need to merge it into the module.

SerShevchyk opened merge request !31

sershevchyk’s picture

sershevchyk
Primary language Ukrainian
Location Lutsk
commented
Status: Needs work » Needs review
mariamk’s picture

mariamk commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new facet-form-button-labels-translation-3274513-3.patch551 bytes

I've updated the patch. I'm not really sure how to test it though!

smulvih2’s picture

smulvih2
Location Canada 🍁
commented

Patch #7 is the exact same as patch #2 BTW.

The last submitted patch, 2: facets-form-button-labels-translation-3274513-2.patch, failed testing. View results

Andras_Szilagyi made their first commit to this issue’s fork.

andras_szilagyi’s picture

andras_szilagyi commented
Status: Reviewed & tested by the community » Fixed

Thank you, merged.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

proweb.ua’s picture

proweb.ua commented

facets_form 1.x-dev
button labels translatable are not translated.

I disabled the module, deleted it through the composer. clear cache and run cron

proweb.ua’s picture

proweb.ua commented

src/Form/FacetsForm.php

    $form['actions']['submit'] = [
      '#type' => 'submit',
      '#value' => $config['button']['label']['submit'],
    ];

add t()

    $form['actions']['submit'] = [
      '#type' => 'submit',
      '#value' => t($config['button']['label']['submit']),
    ];

after that the translation starts working

andras_szilagyi’s picture

andras_szilagyi commented

@proweb.ua unfortunately the entity translation picks up the schema changes only on module install or re-install, in effect you would not translate configuration via string translation using t() but (after reinstall) enable the translation for block configuration.