Problem/Motivation

As suggested in the Accessibility | Tippy.js documentation:

Tooltips should only be applied to natively focusable elements like <button> or <input>. If you are using a <div> or <span> element, ensure you add tabindex="0" so that it can receive focus.

Steps to reproduce

At the moment, text or images with tooltips do not received tab focus and the tooltip is therefore not displayed.

Proposed resolution

Add the tabindex=0 attribute.

Remaining tasks

Provide patch

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#6 3274092-use-natively-focusable-elements.patch1.4 KBroberto.rivera.ixis

Issue fork ckeditor_tippy-3274092

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

  • 1.0.x Comparechanges, plain diff MR !2
  • 3274092 Comparecompare
About issue forks

Comments

stefanos.petrakis created an issue. See original summary.

stefanos.petrakis opened merge request !2

stefanos.petrakis’s picture

stefanos.petrakis
Primary language English
Location Biel, Switzerland
commented
Status: Active » Needs review

Ready for review

iancawthorne’s picture

iancawthorne commented
Status: Needs review » Reviewed & tested by the community

Reviewed and works. +1 for committing this patch please!

stefanos.petrakis’s picture

stefanos.petrakis
Primary language English
Location Biel, Switzerland
commented
Issue summary: View changes
roberto.rivera.ixis’s picture

roberto.rivera.ixis commented
StatusFileSize
new 3274092-use-natively-focusable-elements.patch1.4 KB

Attaching patch from stefanos.petrakis work.

anthelixes made their first commit to this issue’s fork.

anthelixes’s picture

anthelixes commented
anthelixes’s picture

anthelixes commented
anthelixes’s picture

anthelixes commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.