Problem/Motivation

We should add interfaces before there is too much code written directly using the class names.

  • All services
  • MailerPolicy
  • MailManagerReplacement
  • DONE EmailFactory
  • Check for others

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#10 symfony_mailer.add_interfaces.3274069-interdiff-9-10.txt4.21 KBadamps
#10 symfony_mailer.add_interfaces.3274069-10.patch15.93 KBadamps
#9 symfony_mailer.add_interfaces.3274069-interdiff-7-9.txt907 bytesadamps
#9 symfony_mailer.add_interfaces.3274069-9.patch11.65 KBadamps
#7 symfony_mailer.add_interfaces.3274069-interdiff-6-7.txt6.8 KBadamps
#7 symfony_mailer.add_interfaces.3274069-7.patch11.56 KBadamps
#6 symfony_mailer.add_interfaces.3274069.6.patch15.12 KBjaypan
#2 symfony_mailer.interfaces.3274069-2.patch3.93 KBadamps

Comments

AdamPS created an issue. See original summary.

adamps’s picture

adamps commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new symfony_mailer.interfaces.3274069-2.patch3.93 KB

  • AdamPS committed 0fe37e9 on 1.x 
    Issue #3274069 by AdamPS: Add interfaces
adamps’s picture

adamps commented
Issue summary: View changes
Status: Needs review » Active
adamps’s picture

adamps commented
Issue summary: View changes
jaypan’s picture

jaypan
Location Victoria, BC
commented
Status: Active » Needs review
StatusFileSize
new symfony_mailer.add_interfaces.3274069.6.patch15.12 KB
adamps’s picture

adamps commented
StatusFileSize
new symfony_mailer.add_interfaces.3274069-7.patch11.56 KB
new symfony_mailer.add_interfaces.3274069-interdiff-6-7.txt6.8 KB

I came to work on this issue and found a patch already - great many thanks. My comments are based on comparison with core. I made a new patch myself, please can you check?

1) Compare for example ImageStyleInterface, I think we want

interface MailerPolicyInterface extends ConfigEntityInterface

and 

interface MailManagerReplacementInterface extends MailManagerInterface

2) Controllers that extend ControllerBase apparently never have interfaces.

3) EmailAdjusterManager needs an interface

Status: Needs review » Needs work

The last submitted patch, 7: symfony_mailer.add_interfaces.3274069-7.patch, failed testing. View results

adamps’s picture

adamps commented
Status: Needs work » Needs review
StatusFileSize
new symfony_mailer.add_interfaces.3274069-9.patch11.65 KB
new symfony_mailer.add_interfaces.3274069-interdiff-7-9.txt907 bytes
adamps’s picture

adamps commented
StatusFileSize
new symfony_mailer.add_interfaces.3274069-10.patch15.93 KB
new symfony_mailer.add_interfaces.3274069-interdiff-9-10.txt4.21 KB
adamps’s picture

adamps commented
Status: Needs review » Fixed

  • AdamPS committed 8d84c41 on 1.x 
    Issue #3274069 by AdamPS, Jaypan: Add interfaces

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.