After following the steps from the CKEditor5 update path test page I noticed that on existing content, the <h1> element got stripped. Problem is the <h1> config to make the HTML tag allowed, get's lost.
Have a full html text format with h1-h6 enabled on CKEditor.
Update to CKEditor5.
View the node with the <h1> and the <h1> get's stripped, instead of being rendered.
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes, plain diff MR !2060
Comments
Comment #2
joevagyok commentedComment #3
wim leersComment #4
wim leersWe've identified the root cause of the bug:
in
\Drupal\ckeditor5\Plugin\CKEditor4To5Upgrade\Core::computeCKEditor5PluginSubsetConfiguration()should be🤣
Simple fix. 👍
But first we need a failing test 🤓 I asked @joevagyok to add a new test case to
\Drupal\Tests\ckeditor5\Kernel\SmartDefaultSettingsTest::provider()— that should fail. And then applying the fix should result in tests passing :)Comment #5
wim leersComment #7
joevagyok commentedComment #8
wim leersThat looks great! 🤩
As soon as tests come back red and green, I'll RTBC! 🤓
Comment #9
wim leersIt seems @joevagyok confused either GitLab or DrupalCI by using
git push --force😬 Hence those 4 trivial commits by me to prove that this MR is indeed failing when expected and fixing the bug!Comment #10
alexpottCommitted and pushed a1244cefd5 to 10.0.x and 307e3b7a4e to 9.4.x and 03a0f1f2a3 to 9.3.x. Thanks!