Passing null to parameter #1 ($haystack) of type string to strpos() is deprecated

Working on this

Hope it helps!

Setting up a new site, I'm getting this, and other similar error messages as well, though Colorbox is working beautifully.

in addition the the above:

Deprecated function: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in template_preprocess_colorbox_formatter() (line 88 of ... \web\modules\contrib\colorbox\colorbox.theme.inc)

Drupal 9, all modules up to date. Using Bootstrap 5 theme.
Colorbox Version: 8.x-1.8

No errors. Working fine.

Really makes sense. +1 to RTBC

Merged to the dev branch

Thank you so much @victoria-marina and everyone for your contribution

I love Colorbox. Thank you for the quick fix!

Sorry for asking, but how do I make a patch file out of this?

Still have this problem

Error message
Deprecated function: strlen(): Passing null to parameter #1 ($string) of type string is deprecated in template_preprocess_colorbox_formatter() (line 115 of modules/contrib/colorbox/colorbox.theme.inc).
template_preprocess_colorbox_formatter(Array, 'colorbox_formatter', Array) (Line: 287)
Drupal\Core\Theme\ThemeManager->render('colorbox_formatter', Array) (Line: 422)
Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 201)
Drupal\Core\Render\Renderer->render(Array) (Line: 479)

how to fix

```diff
// Do not output an empty 'title' attribute.
- if (strlen($item->title) != 0) {
+ if (strlen((string) $item->title) != 0) {
```

That is a different error message, although similar to the one reported in the issue summary.

We can either leave this issue closed and create a new issue, or re-open this and update the issue summary; in the latter case, it would be better to fix all similar errors.
Usually, once the issue is marked fixed, it's not re-opened, but that is a decision the project maintainers make.

If we are going to fix also the following code, I would not convert $item->title to a string.

// Do not output an empty 'title' attribute.
if (strlen($item->title) != 0) {
  $variables['image']['#title'] = $item->title;
  $data_cbox_img_attrs['title'] = '"title":"' . $item->title . '"';
}

It's sufficient to use the following code.

// Do not output an empty 'title' attribute.
if (!empty($item->title)) {
  $variables['image']['#title'] = $item->title;
  $data_cbox_img_attrs['title'] = '"title":"' . $item->title . '"';
}

The patch works perfectly, thanks

The tests fail, but it's because I selected MySQL 5.6 and Drupal 9.3, when Drupal 9.3 requires MySQL 5.7.

The database server version 5.6.40 is less than the minimum required version 5.7.8.

Really looks good. Thanks a lot

Committed to the 8.x-1.x branch. Thank you so much everyone for your job on this

Worked for me!
Thanks for the quick fix.