Because of #3083275: [meta] Update tests that rely on Classy to not rely on it anymore and Classy being deprecated in Drupal 9 + removed in Drupal 10,: Tests that aren't specifically testing Classy yet declare $defaultTheme = 'classy'; should be refactored to use Stark as the default theme instead.
Change all tests in this module to use Stark as the default theme, and refactor the tests where needed so they continue to function properly.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | interdiff_2-3.txt | 1.05 KB | danflanagan8 |
| #3 | 3272558-3.patch | 10.03 KB | danflanagan8 |
| #2 | 3272558-2.patch | 8.98 KB | danflanagan8 |
Comments
Comment #2
danflanagan8This one got created a little late alphabetically because it's one of the modules that was "soft blocked" by the issue to create the new WebAssert methods for status messages. That new method is used to decouple from classy in
ContentTranslationSettingsTest. But I also went ahead and refactored a number of other assertions to use the new methods.This one is pretty small and the review should be easy!
Comment #3
danflanagan8I just decided to do a search for tests that used stark and also contained the string "messages--" in an attempt to find bogus status message assertions and it turns out there was one in this module!
So here's an updated patch that fixes what is truly a bug in a test already using stark, but making a negative assertion that relies on classy markup.
Comment #4
larowlanMakes sense to me
Comment #5
alexpottCommitted and pushed 22c29deda4 to 10.0.x and 0a5c3527fb to 9.5.x and 07db513b77 to 9.4.x. Thanks!
Comment #9
alexpottGoing to test on 9.3.x and backport there if green.
Comment #10
alexpottGlad I didn't commit this to 9.3.x