Problem/Motivation
As of version ^4.1 of VBO, the changes introduced in the issue: https://www.drupal.org/project/views_bulk_operations/issues/3246212 generate conflicts.
These occur because, depending on the interface "/Drupal/Core/Action/Action/ActionInterface.php" in the access function, the return can be an object or a boolean, depending on the argument $return_as_object which by default is set to FALSE.
In case $return_as_object = TRUE, the "VboEnqueue.php" access function should return the object and currently this is not contemplated.
Proposed resolution
Return AccessResult::forbidden when $valid is FALSE, and AccessResult::allowed() when $valid is TRUE, in the case $return_as_object is TRUE. All this it must be done in the access method.
Issue fork 3123586-3272423
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
albeorte commentedComment #3
omarlopesinoUpdated the proposed resolution with detailed guidelines. I propose you to do those changes, check that everything works fine after updating the module.
Comment #4
elberComment #6
albeorte commentedUpdates done.
Working properly, please review the changes.
Comment #7
omarlopesinoComment #9
omarlopesinoThe MR looks good to me. Marking the issue as fixed as I've just merged the MR. Thanks!
Comment #10
albeorte commented