Problem/Motivation

Because of #3083275: [meta] Update tests that rely on Classy to not rely on it anymore and Classy being deprecated in Drupal 9 + removed in Drupal 10,: Tests that aren't specifically testing Classy yet declare $defaultTheme = 'classy'; should be refactored to use Stark as the default theme instead.

Proposed resolution

Change all tests in this module to use Stark as the default theme, and refactor the tests where needed so they continue to function properly.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3272354-2.patch6.64 KBdanflanagan8

Comments

danflanagan8 created an issue. See original summary.

danflanagan8’s picture

danflanagan8
Primary language English
Location St. Louis, US
commented
Assigned: danflanagan8 » Unassigned
Status: Active » Needs review
StatusFileSize
new 3272354-2.patch6.64 KB

This one only has a single test with a single line that needed to be changed. Sooooo, I went ahead and updated all the status message assertions I could find to use the new WebAssert methods. That gives us a little more value from this patch without making the review significantly harder.

Status: Needs review » Needs work

The last submitted patch, 2: 3272354-2.patch, failed testing. View results

danflanagan8’s picture

danflanagan8
Primary language English
Location St. Louis, US
commented
Status: Needs work » Needs review

That was a random quickedit failure. This is ready for review.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Reviewed & tested by the community

Nice cleanup

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed ba111c104d to 10.0.x and d9a2db8b8d to 9.5.x and 10ed5d1d26 to 9.4.x. Thanks!

  • alexpott committed ba111c1 on 10.0.x 
    Issue #3272354 by danflanagan8: Filter tests should not rely on Classy

  • alexpott committed d9a2db8 on 9.5.x 
    Issue #3272354 by danflanagan8: Filter tests should not rely on Classy...

  • alexpott committed 10ed5d1 on 9.4.x 
    Issue #3272354 by danflanagan8: Filter tests should not rely on Classy...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.