I've been testing this out on my preview site and as far as I can tell if the comments are moderated (as I'd like anon comments to be on my site) they do not generate emails, either when they are written (which would be the wrong time) or when they are finally published (which would be the right time). This means if any user signs up for updates, then if comments are moderated for any other class of users the original user won't receive updates for the moderated class of users.

CommentFileSizeAuthor
#16 327211_notify_for_moderated_comments.patch1.39 KBgreggles
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented

I'll have to investigate this issue. It may be related to the way that the publish operation of hook_comment was implemented in Drupal 6.x.

Have you tried it without comment moderation? Can you confirm it works in that situation?

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented
Status: Active » Postponed (maintainer needs more info)

I just tried this and it worked fine for me. Note that comment_notify will leave a message in the watchdog for every e-mail it sends, so you can figure out if it is a comment_notify issue (nothing in watchdog) or a mail server issue (message in watchdog, no mail).

Also, comment notify doesn't send messages to the comment author for their comments.

bejayoharen’s picture

bejayoharen CreditAttribution: bejayoharen commented

Yes, it works fine for unmoderated users, so I don't think it's a mailserver issue. I tried with a variety of emails and users. I will try again and check the logs. FYI: I did not know what you meant by watchdog b/c it is no longer called that in Drupal 6.

bejayoharen’s picture

bejayoharen CreditAttribution: bejayoharen commented

Anon users on my system get their comments moderated, so here's what I did:

- made an anon comment. (asked to be notified)
- let it through.
- made another anon comment with another email. (also asked to be notfied)
- let it through.
- checked logs. Nothing. and never received emails. (admin/reports/dblog)
- made a comment as a privileged user. (again asked to be notified, but I guess that's neither here nor there)
- checked logs. it said it sent two emails, and by that time I had had two emails in my inbox, one to each email addy I had for each previous comment.

Thanks for your help so far.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented

Sorry, I forgot that watchdog is now dblog ;)

One thing I would suggest is to use the 6.x-1.x-dev version. 6.x-1.1 has a lot of serious holes and I am about to make a 6.x-1.2 from the 6.x-1.x-dev.

I will try to run through the scenario you describe.

bejayoharen’s picture

bejayoharen CreditAttribution: bejayoharen commented

Seems to be doing the same thing, I'm afraid.

lupo’s picture

lupo CreditAttribution: lupo commented

Hi.

I am experiencing this same issue. Moderated comments, no emails about posted comments.

I just thought I should mention it as the module description does ask to have problems noted here so they can be worked on.

Thank you for your efforts with this module. I appreciate it very much.

Dave

gemini’s picture

gemini CreditAttribution: gemini commented

Since I posted a duplicate issue, I'm subscribing here.

akael’s picture

akael CreditAttribution: akael commented

I am having the same issue, has this been resolved yet?

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented

I did some more investigation into hook_comment and I'm not sure of the best way to solve it.

Comment Notify relies on hook_comment being called with "publish" as the operation. That works fine in some cases, but not when a comment is moved from unpublished to published. Frankly, there is a lot of inconsistency in the way that hook_comment is called and when the different operations are or are not used.

Would it be impossible to use unmoderated comments on your sites? Comment notify should work fine with Captch/ReCaptch/Mollom based solutions to prevent spam.

bejayoharen’s picture

bejayoharen CreditAttribution: bejayoharen commented

We expect to have concerns other than spam on our site: preserving anonymity, fostering a community spirit, etc.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented

This is likely to be fixed by #334735: Remove patching core dependency. I'm tempted to mark this as a duplicate.

Note that #334735: Remove patching core dependency is dependent on #186025: Distinguish between new comments and comment edits.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented
Status: Postponed (maintainer needs more info) » Closed (duplicate)

I've now fixed #334735: Remove patching core dependency for 6.x. So, I think this is fixed. When a new tarball of 6.x-1.x-dev is created in a few hours, please help test it out. I plan to create a new release of the module in the next few days.

bejayoharen’s picture

bejayoharen CreditAttribution: bejayoharen commented
Version: 6.x-1.1 » 7.x-1.x-dev

no, still not working.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented
Status: Closed (duplicate) » Active

Hmmm - ok.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented
Status: Active » Needs review
FileSize
327211_notify_for_moderated_comments.patch1.39 KB

Ok, here's a patch that I believe solves this issue.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented
Status: Needs review » Patch (to be ported)

I've now committed this to the 6.x branch http://drupal.org/cvs?commit=180162

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented
Version: 7.x-1.x-dev » 5.x-2.x-dev

I forgot to change the Version to 5.x.

If it's not working for 6.x please re-open and move back to 6.x.

gsgchoi’s picture

gsgchoi CreditAttribution: gsgchoi commented

I am using drupal 6.x and it doesn't send any email if I use comment approval queue. Is this bug already known as fixed? Please let me know about the latest update! However when I tried it, it didn't work.

gsgchoi’s picture

gsgchoi CreditAttribution: gsgchoi commented

I am storing anonymous comments in approval queue and this doesn't send any email once it publishes new comments. Is this known as fixed? Please let me know about the latest status.
I checked dblog and I don't see any email sending action thus I assume that this is not a mail server problem.

gsgchoi’s picture

gsgchoi CreditAttribution: gsgchoi commented
Version: 5.x-2.x-dev » 7.x-1.x-dev

FYI, I am using Drupal 6.x

otavio’s picture

otavio CreditAttribution: otavio commented
Version: 7.x-1.x-dev » 5.x-2.x-dev

On the same boat here.

Installed 5.x-2.x-dev, patched the core comment module but can only get notification if moderation is off.

Is this working i D6?

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented

I believe it is working in d6 - I tested it a while ago when I committed the patch, but have not tested recently.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented
Status: Patch (to be ported) » Closed (fixed)

This module is no longer actively developed for Drupal 5. If someone wishes to take over as the 5.x maintainer I would consider it, but these days everyone should really upgrade to Drupal 6.x.