Problem/Motivation

After switching to PHP8 appeared warning "Expected an object instance when accessing an instance property, but saw an expression $format with type false on lines 212, 215, 216"

CommentFileSizeAuthor
#18 media-3271990-php-8.0-compatibility.patch1.55 KBDmitrii_Zadorozhnyi
#2 media-3271990-php-8.0-compatibility.patch1.54 KBDmitrii_Zadorozhnyi

Comments

Dmitrii_Zadorozhnyi created an issue. See original summary.

Dmitrii_Zadorozhnyi’s picture

Dmitrii_Zadorozhnyi commented
StatusFileSize
new media-3271990-php-8.0-compatibility.patch1.54 KB

I would suggest to apply a patch

  • joseph.olstad committed c403a77 on 7.x-2.x 
    Issue #3271990 by joseph.olstad: PHP 8.0 compatibility. Expected an...

  • joseph.olstad committed f659dec on 7.x-3.x 
    Issue #3271990 by joseph.olstad: PHP 8.0 compatibility. Expected an...

  • joseph.olstad committed 5016d88 on 7.x-4.x 
    Issue #3271990 by joseph.olstad: PHP 8.0 compatibility. Expected an...
joseph.olstad’s picture

joseph.olstad
Primary language French
commented

keeping php 5.3 array( syntax to maintain backwards compatibility.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

this is pushed into dev, please test

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

not sure if this is the right fix, needs review, it's in dev for now.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

tests fail, reverting

  • joseph.olstad committed b63b78d on 7.x-4.x 
    Issue #3271990 by Dmitrii_Zadorozhnyi, joseph.olstad: REVERT COMMIT...

  • joseph.olstad committed 47f4e2d on 7.x-3.x 
    Issue #3271990 by Dmitrii_Zadorozhnyi, joseph.olstad: REVERT COMMIT...

  • joseph.olstad committed 6d77794 on 7.x-2.x 
    Issue #3271990 by Dmitrii_Zadorozhnyi, joseph.olstad: REVERT COMMIT...
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs review » Needs work

patch fails tests, causes regressions

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs work » Active

Hmm, it might not have been the patch causing the fail, the test fails revolve around 'token'

so likely the 'token' module was changed in the past 12 months and broke something

Investigate changes in the 'token' module

Dmitrii_Zadorozhnyi’s picture

Dmitrii_Zadorozhnyi commented
StatusFileSize
new media-3271990-php-8.0-compatibility.patch1.55 KB

Fix short array syntax

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Active » Needs review

looks good, going to push this in.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

pushing releases with this fix

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.