Problem/Motivation

Clearly a good idea for code stability

Proposed resolution

Test framework

symfony_mailer_test module containing MailerTestService that processes emails. In postRender() set the transport to null://default, and in postSend() store the Email objects in Drupal state.

MailerTestTrait provides accessor functions for the email queue and asserts for checking emails.

Test cases

Initially just test the Test email.

Remaining tasks

#3278446: Add more tests

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#26 symfony_mailer.tests_.3271802-24.patch15.26 KBadamps
#24 symfony_mailer.tests_.3271802-24.patch15.26 KBadamps
#21 symfony_mailer.tests_.3271802-21.patch668 bytesadamps
#18 symfony_mailer.tests_.3271802-18.patch2.26 KBadamps
#16 symfony_mailer.tests_.3271802-16.patch2.25 KBadamps
#14 symfony_mailer.tests_.3271802-14.patch1.45 KBadamps
#13 symfony_mailer.tests_.3271802-13.patch1.47 KBadamps
#11 symfony_mailer.tests_.3271802-11.patch1.53 KBadamps
#10 symfony_mailer.tests_.3271802-10.patch6.04 KBadamps
#8 symfony_mailer.tests_.3271802-8.patch1.49 KBadamps
#5 symfony_mailer.tests_.3271802-5.patch2.55 KBadamps
#3 symfony_mailer.tests_.3271802-interdiff-2-3.txt5.01 KBadamps
#2 symfony_mailer.tests_.3271802-2.patch7.75 KBadamps
#3 symfony_mailer.tests_.3271802-3.patch7.95 KBadamps

Comments

AdamPS created an issue. See original summary.

adamps’s picture

adamps commented
Status: Active » Needs work
StatusFileSize
new symfony_mailer.tests_.3271802-2.patch7.75 KB

Work in progress

adamps’s picture

adamps commented
Status: Needs work » Needs review
StatusFileSize
new symfony_mailer.tests_.3271802-3.patch7.95 KB
new symfony_mailer.tests_.3271802-interdiff-2-3.txt5.01 KB

  • AdamPS committed c33a67e on 1.x 
    Issue #3271802 by AdamPS: Write automatic tests
adamps’s picture

adamps commented
StatusFileSize
new symfony_mailer.tests_.3271802-5.patch2.55 KB

Status: Needs review » Needs work

The last submitted patch, 5: symfony_mailer.tests_.3271802-5.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

  • AdamPS committed afc27e4 on 1.x 
    Issue #3271802 by AdamPS: Write automatic tests
adamps’s picture

adamps commented
Status: Needs work » Needs review
StatusFileSize
new symfony_mailer.tests_.3271802-8.patch1.49 KB

Status: Needs review » Needs work

The last submitted patch, 8: symfony_mailer.tests_.3271802-8.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

adamps’s picture

adamps commented
Status: Needs work » Needs review
StatusFileSize
new symfony_mailer.tests_.3271802-10.patch6.04 KB
adamps’s picture

adamps commented
StatusFileSize
new symfony_mailer.tests_.3271802-11.patch1.53 KB

Status: Needs review » Needs work

The last submitted patch, 11: symfony_mailer.tests_.3271802-11.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

adamps’s picture

adamps commented
Status: Needs work » Needs review
StatusFileSize
new symfony_mailer.tests_.3271802-13.patch1.47 KB
adamps’s picture

adamps commented
StatusFileSize
new symfony_mailer.tests_.3271802-14.patch1.45 KB

Status: Needs review » Needs work

The last submitted patch, 14: symfony_mailer.tests_.3271802-14.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

adamps’s picture

adamps commented
Status: Needs work » Needs review
StatusFileSize
new symfony_mailer.tests_.3271802-16.patch2.25 KB

Status: Needs review » Needs work

The last submitted patch, 16: symfony_mailer.tests_.3271802-16.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

adamps’s picture

adamps commented
Status: Needs work » Needs review
StatusFileSize
new symfony_mailer.tests_.3271802-18.patch2.26 KB

Status: Needs review » Needs work

The last submitted patch, 18: symfony_mailer.tests_.3271802-18.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

adamps’s picture

adamps commented

Aha __serialize() is only supported from PHP 7.4 onwards d'oh!!

adamps’s picture

adamps commented
Status: Needs work » Needs review
StatusFileSize
new symfony_mailer.tests_.3271802-21.patch668 bytes

  • AdamPS committed c595be3 on 1.x 
    Issue #3271802 by AdamPS: Write automatic tests
adamps’s picture

adamps commented
Title: Write automatic tests » Automatic test framework
Issue summary: View changes
adamps’s picture

adamps commented
StatusFileSize
new symfony_mailer.tests_.3271802-24.patch15.26 KB

  • AdamPS committed b75f835 on 1.x 
    Issue #3271802 by AdamPS: Automatic test framework
adamps’s picture

adamps commented
Status: Needs review » Fixed
StatusFileSize
new symfony_mailer.tests_.3271802-24.patch15.26 KB

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.