Problem/Motivation

Instead of having it just a Javascript-based change, it might be useful for some web site owners to be able to add this as a Drupal block.
If the block is enabled on a page, the Javascript should detect it and not show up.

CommentFileSizeAuthor
#9 Screenshot from 2022-03-24 15-58-40.png38.02 KBruturaj chaubey
#8 stand-with-ukraine-block-14456118-8.patch2.57 KBomkar-pd
#3 stand_with_ukrain.png262.11 KBomkar-pd
#3 stand-with-ukraine-block-14456118-3.patch2.57 KBomkar-pd

Comments

jcnventura created an issue. See original summary.

omkar-pd’s picture

omkar-pd commented
Assigned: Unassigned » omkar-pd
omkar-pd’s picture

omkar-pd commented
Assigned: omkar-pd » Unassigned
Status: Active » Needs review
StatusFileSize
new stand-with-ukraine-block-14456118-3.patch2.57 KB
new stand_with_ukrain.png262.11 KB
  • Added Stand With Ukraine Banner as a Block.
  • If user places the block in any region then js library won't we attached.
  • If user disables/remove the block then the original js library will be attached and banner will be displayed again.
  • Followed all the coding standards as well.
ruturaj chaubey’s picture

ruturaj chaubey
He/Him
Primary language English
Location Pune, India
commented
Assigned: Unassigned » ruturaj chaubey

Will review this.

ruturaj chaubey’s picture

ruturaj chaubey
He/Him
Primary language English
Location Pune, India
commented 
+++ b/stand_with_ukraine.libraries.yml
@@ -1,9 +1,12 @@
+styling: ¶

This line adds whitespace error. Please solve this.

ruturaj chaubey’s picture

ruturaj chaubey
He/Him
Primary language English
Location Pune, India
commented
Assigned: ruturaj chaubey » Unassigned
Status: Needs review » Needs work
omkar-pd’s picture

omkar-pd commented
Assigned: Unassigned » omkar-pd

Will work.

omkar-pd’s picture

omkar-pd commented
Assigned: omkar-pd » Unassigned
Status: Needs work » Needs review
StatusFileSize
new stand-with-ukraine-block-14456118-8.patch2.57 KB

fixed.

ruturaj chaubey’s picture

ruturaj chaubey
He/Him
Primary language English
Location Pune, India
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screenshot from 2022-03-24 15-58-40.png38.02 KB

The patch is working fine. Refer the image file for results.

  • cmd87 committed babc1f5 on 1.0.x authored by omkar-pd 
    Issue #3271375 by omkar-pd, Ruturaj Chaubey, jcnventura: Show the banner...
cmd87’s picture

cmd87 commented
Status: Reviewed & tested by the community » Fixed

Thank you guys! Patch applied and new version released.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.