Problem/Motivation

FILE: /app/web/modules/contrib/toastr/js/messages.js
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
 11 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
 12 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: /app/web/modules/contrib/toastr/src/Form/ToastrSettingsForm.php
----------------------------------------------------------------------
FOUND 13 ERRORS AND 2 WARNINGS AFFECTING 15 LINES
----------------------------------------------------------------------
   1 | ERROR   | [x] The PHP open tag must be followed by exactly one
     |         |     blank line
   4 | ERROR   | [x] There must be one blank line after the namespace
     |         |     declaration
  11 | ERROR   | [x] Doc comment short description must end with a
     |         |     full stop
  14 | WARNING | [ ] The class short comment should describe what the
     |         |     class does and not simply repeat the class name
  20 | ERROR   | [ ] Description for the @return value is missing
  38 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: 1
  72 | ERROR   | [ ] Description for the @return value is missing
 135 | ERROR   | [x] Expected 1 space before "=>"; 0 found
 143 | ERROR   | [x] Expected 1 space before "=>"; 0 found
 151 | ERROR   | [x] Expected 1 space before "=>"; 0 found
 159 | ERROR   | [x] Expected 1 space before "=>"; 0 found
 184 | ERROR   | [x] Expected 1 space before "=>"; 0 found
 193 | ERROR   | [x] Expected 1 space before "=>"; 0 found
 202 | ERROR   | [x] Expected 1 space before "=>"; 0 found
 211 | ERROR   | [x] Expected 1 space before "=>"; 0 found
----------------------------------------------------------------------

Comments

omkar-pd created an issue. See original summary.

omkar-pd’s picture

Assigned: omkar-pd » Unassigned
Status: Active » Needs review
StatusFileSize
new4.8 KB
libbna’s picture

StatusFileSize
new26.64 KB
new32.77 KB

I have reviewed the #2 patch and it LGTM. Added screenshots.

libbna’s picture

Status: Needs review » Reviewed & tested by the community

  • omkar-pd committed 17d11de on 8.x-1.x
    Issue #3271358 by omkar-pd, Libbna: Fix Coding Standards
    
omkar-pd’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.