Problem/Motivation

When using in conjunction with external_entities module, and trying to execute "rebuild tracking information", the batch is never ending.
The reason is that Drupal\external_entities\Entity\Query\External\Query didn't support condition queries properly, and even if it supports it, it will rely on the third party API implementation

Steps to reproduce

Proposed resolution

Skip the condition
$select->condition($entity_id, $last_ids[$context_key]['last_id'], '>');
when the query is a external_entities query, as it skips that condition when the getEntityTypeId is search_api_task

Remaining tasks

Issue fork search_api-3271256

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

akalam created an issue. See original summary.

akalam’s picture

akalam’s picture

Status: Active » Needs review
drunken monkey’s picture

Component: General code » Plugins
StatusFileSize
new1.26 KB
new1.23 KB

Thanks a lot for reporting this problem and already providing a fix! Also, sorry it took me so long to get back to you!
Note, however, that testing unfortunately doesn’t work for MRs in this project (see #3190024: Problem with test dependencies when testing issue forks), so we’ll have to work with patches for now.

Posting a slightly adapted version as a patch – please test/review and I can commit it.

drunken monkey’s picture

Status: Needs review » Fixed

Committed. Thanks again!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.