Closed (fixed)
Project:
Metatag
Version:
7.x-1.x-dev
Component:
Tests
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
22 Mar 2022 at 14:43 UTC
Updated:
12 Apr 2022 at 02:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
damienmckennaThis adds the dependency.
Comment #3
damienmckennaComment #4
damienmckennaComment #6
damienmckennaCommitted.
Now to see if enabling the Date module fixes the problem.
Comment #7
damienmckennaDoes this work?
Comment #9
damienmckennaThe "date" token type comes from system.tokens.inc:
So in theory this should always be present.
I would not be surprised if this was caused by a core bug in core.
Comment #11
damienmckennaI reverted the test dependency addition.
Comment #12
damienmckennaI wonder if the problem is #1934192?
Comment #13
damienmckennaThe last test that succeeded was last October: https://dispatcher.drupalci.org/job/drupal_d7/166123/console
The main differences, besides months of changes to Drupal core, are:
* ctools 7.x-1.19 instead of 1.20
* entity 7.x-1.9 Instead of 1.10
* entity_translation 7.x-1.1 instead of 2.0
* file_entity 7.x-2.32 instead of 2.36
* token 7.x-1.8 instead of 1.9
Comment #14
damienmckennaInterestingly enough I cannot reproduce the problem locally - the test that fails on drupalci runs just fine for me.
Comment #15
feyp commentedWhen running just MetatagCoreNodeTest.test I'm seeing the same exceptions locally in verbose mode:
Comment #16
feyp commentedCould this possibly have been introduced by #2128055: Files should be uploaded to per year/month directories by default? If the tests are only run on commit, this would also fit your timeline, it was released in December and the last commit before that was in October.
Attached are two patches, that are probably not the final solution (especially the 2nd one), but let's see, if that would fix the problem.
I hope you don't mind me working on this even though you had this assigned to yourself. I thought that since you couldn't reproduce locally, I might as well have a look. If it's not helpful, just let me know.
Backtrace:
With arguments (only the first 4 steps):
Comment #17
damienmckennaThank you, I really appreciate it.
Comment #18
damienmckennaA related core issue: #1173706
Comment #19
damienmckennaComment #20
damienmckennaLet's pull it out a bit further.
Comment #21
damienmckennaComment #22
damienmckennaCommitted. Thanks FeyP!
Comment #24
joseph.olstadI have the same issue in the media module
down from 4 errors to just 1 now
having problems figuring out the last error.
#3272112: MEDIA - Tests break due to change in core's default file field path settings