Problem/Motivation

Deprecate Color module - part of #3270894: [Meta] Tasks to deprecate Color

Proposed resolution

Use https://www.drupal.org/about/core/policies/core-change-policies/module-o...

What the MR does

- Deprecates the Color module by adding appropriate lifecycle and lifecycle_link to core/modules/color/color.info.yml
- Adds @group legacy to all tests in the Drupal\Tests\color\* namespace
- Removes the dependency on the Color module from the demo_umami profile. This dependency seems only to be there since the Color module was (until recently) enabled in the Standard Profile, and this profile just copied that.

User interface changes

no

API changes

no

Data model changes

no

Release notes snippet

Color module is deprecated

CommentFileSizeAuthor
#3 3270936-3.patch12.61 KBquietone
#3 interdiff-2-3.txt9.81 KBquietone
#2 3270936-2.patch2.8 KBquietone

Issue fork drupal-3270936

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone’s picture

quietone commented
StatusFileSize
new 3270936-2.patch2.8 KB

Making a start.

quietone’s picture

quietone commented
Status: Active » Needs review
StatusFileSize
new interdiff-2-3.txt9.81 KB
new 3270936-3.patch12.61 KB

Add @legacy to migration tests that use the standard profile.

Status: Needs review » Needs work

The last submitted patch, 3: 3270936-3.patch, failed testing. View results

quietone’s picture

quietone commented
Status: Needs work » Postponed

Postponing on all the issues in Step 1 of #3270894: [Meta] Tasks to deprecate Color

quietone’s picture

quietone commented
Issue tags: +Needs change record
catch’s picture

catch
he/him
Primary language English
commented
Status: Postponed » Needs work

Not sure if this is fully unblocked, because Bartik still has color support, but... it might be unblocked so let's see.

catch’s picture

catch
he/him
Primary language English
commented
Issue tags: +Needs reroll
spokje’s picture

spokje
Primary language Dutch
commented
Assigned: Unassigned » spokje
spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes

Spokje opened merge request !2137

spokje’s picture

spokje
Primary language Dutch
commented

Rather modestly sized PR for a deprecation this time:

- Deprecates the Color module by adding appropriate lifecycle and lifecycle_link to core/modules/color/color.info.yml
- Adds @group legacy to all tests in the Drupal\Tests\color\* namespace
- Moves Color in tests in the Drupal\Tests\aggregator\Functional\migrate_drupal_ui\d7 namespace from getAvailablePaths() to getMissingPaths()
- Removes the dependency on the Color module from the demo_umami profile. This dependency seems only to be there since the Color module was (until recently) enabled in the Standard Profile, and this profile just copied that.

andypost’s picture

andypost
he/him
Primary language Russian
commented

I think patch will be better as there's no way to test it against 10.0.x

spokje’s picture

spokje
Primary language Dutch
commented

I think patch will be better as there's no way to test it against 10.0.x

@andypost: At this moment in time I'm very unsure if the deprecation on D9.4.x will be tested on D10.0.x.
I _think_ the actual removal patch/PR in D10.0.x will be the only test done on D10.0.x and both deprecation and removal will be committed within 24hrs of each other when both are RTBC , but as said: I _think_

But I'm sure Bigger Brains than mine can confirm/deny the above. I'm happy to provide a patch by then.

spokje’s picture

spokje
Primary language Dutch
commented
Assigned: spokje » Unassigned
Status: Needs work » Needs review
andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Needs work
Issue tags: -Needs change record, -Needs reroll

Added review, not sure why diff showing changes commited in https://git.drupalcode.org/project/drupal/commit/0ad6705

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Reviewed & tested by the community

Please ignore my previous review, comment #12 is right

- Moves Color in tests in the Drupal\Tests\aggregator\Functional\migrate_drupal_ui\d7 namespace from getAvailablePaths() to getMissingPaths()

andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue summary: View changes

Updated IS a bit and created https://www.drupal.org/project/color/releases/1.0.1

andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue summary: View changes
spokje’s picture

spokje
Primary language Dutch
commented
Title: Deprecate Color module » [PP-1] Deprecate Color module
Status: Reviewed & tested by the community » Postponed

This is postponed until Color is (correctly) removed from the Standard Profile in 9.4.x-dev (10.0.x-dev seems to be OK). See #3270941-33: Remove Color module from the Standard profile

spokje’s picture

spokje
Primary language Dutch
commented
Title: [PP-1] Deprecate Color module » Deprecate Color module
Status: Postponed » Reviewed & tested by the community

#3270941: Remove Color module from the Standard profile landed, this time also in 9.4.x, let's see where this MR fares now.

spokje’s picture

spokje
Primary language Dutch
commented
Status: Reviewed & tested by the community » Needs review

Oops

spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes
spokje’s picture

spokje
Primary language Dutch
commented

MR became even smaller:

- Deprecates the Color module by adding appropriate lifecycle and lifecycle_link to core/modules/color/color.info.yml
- Adds @group legacy to all tests in the Drupal\Tests\color\* namespace
- Removes the dependency on the Color module from the demo_umami profile. This dependency seems only to be there since the Color module was (until recently) enabled in the Standard Profile, and this profile just copied that.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

Back to rtbc

lauriii made their first commit to this issue’s fork.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 9.5.x-dev » 9.4.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed f32465f3a4 to 10.0.x and a3056c871e to 9.5.x and 3f26c6b956 to 9.4.x. Thanks!

  • alexpott committed f32465f on 10.0.x 
    Issue #3270936 by Spokje, quietone, andypost, lauriii: Deprecate Color...

  • alexpott committed a3056c8 on 9.5.x 
    Issue #3270936 by Spokje, quietone, andypost, lauriii: Deprecate Color...

  • alexpott committed 3f26c6b on 9.4.x 
    Issue #3270936 by Spokje, quietone, andypost, lauriii: Deprecate Color...

Spokje closed merge request !2137

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue tags: +9.4.0 release notes

This already has a release note snippet, but was not yet tagged for the 9.4 release notes, doing so now!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.