Remove Color module from the Standard profile

No patch to review yet!

This probably needs a reroll after #3270897: Handle migration tests for removing Color is committed.

Picking it now.

Rerolled the patch against 9.4.x branch & added a reroll diff.

+++ b/core/modules/aggregator/tests/src/Functional/migrate_drupal_ui/d7/MultilingualReviewPageTest.php
@@ -51,7 +51,6 @@ protected function getAvailablePaths() {
-      'Color',

@@ -134,6 +133,7 @@ protected function getMissingPaths() {
+      'Color',

+++ b/core/modules/aggregator/tests/src/Functional/migrate_drupal_ui/d7/NoMultilingualReviewPageTest.php
@@ -48,7 +48,6 @@ protected function getAvailablePaths() {
-      'Color',

@@ -136,6 +135,7 @@ protected function getMissingPaths() {
+      'Color',

+++ b/core/modules/aggregator/tests/src/Functional/migrate_drupal_ui/d7/UpgradeTest.php
@@ -122,7 +122,6 @@ protected function getAvailablePaths() {
-      'Color',

@@ -187,6 +186,7 @@ protected function getAvailablePaths() {
+      'Color',

+++ b/core/modules/help/tests/src/Functional/HelpTest.php
@@ -101,7 +101,7 @@ public function testHelp() {
-    $list = ['Block', 'Color', 'Custom Block', 'History', 'Text Editor'];
+    $list = ['BigPipe', 'Block', 'Custom Block', 'History', 'Text Editor'];

+++ b/core/modules/migrate_drupal_ui/tests/src/Functional/d7/MultilingualReviewPageTest.php
@@ -61,8 +61,6 @@ protected function getAvailablePaths() {
-      // @todo Remove Color in https://www.drupal.org/project/drupal/issues/3270899
-      'Color',

@@ -154,6 +152,8 @@ protected function getMissingPaths() {
+      // @todo Remove Color in https://www.drupal.org/project/drupal/issues/3270899
+      'Color',

+++ b/core/modules/migrate_drupal_ui/tests/src/Functional/d7/NoMultilingualReviewPageTest.php
@@ -57,8 +57,6 @@ protected function getAvailablePaths() {
-      // @todo Remove Color in https://www.drupal.org/project/drupal/issues/3270899
-      'Color',

@@ -157,6 +155,8 @@ protected function getMissingPaths() {
+      // @todo Remove Color in https://www.drupal.org/project/drupal/issues/3270899
+      'Color',

+++ b/core/modules/migrate_drupal_ui/tests/src/Functional/d7/Upgrade7Test.php
@@ -138,8 +138,6 @@ protected function getAvailablePaths() {
-      // @todo Remove Color in https://www.drupal.org/project/drupal/issues/3270899
-      'Color',

@@ -205,6 +203,8 @@ protected function getAvailablePaths() {
+      // @todo Remove Color in https://www.drupal.org/project/drupal/issues/3270899
+      'Color',

--- a/core/modules/page_cache/tests/src/Functional/PageCacheTagsIntegrationTest.php
+++ b/core/modules/page_cache/tests/src/Functional/PageCacheTagsIntegrationTest.php

These changes seem out of scope. These look like re-orders.

I think the only thing that needs to change is removing is from the standard.info.yml and PageCacheTagsIntegrationTest.

This also needs a change record i think. But will ask around to verify.

Made changes as per comment #10.

Change notice added.

+++ b/core/modules/help/tests/src/Functional/HelpTest.php
@@ -101,7 +101,7 @@ public function testHelp() {
-    $list = ['Block', 'Color', 'Custom Block', 'History', 'Text Editor'];
+    $list = ['BigPipe', 'Block', 'Custom Block', 'History', 'Text Editor'];

Why id BigPipe suddenly appearing here? This feels like out of scope as mentioned in #10.

Addressed comment #14.

I think I was very wrong about my comments regarding the unrelated changes. Sorry about that, think my mind was in the mindset of removing this module from core, which is NOT what this issue is about. Sorry about that.

Seems like the patch in #9 is correct. But I don't trust myself anymore today :)

Thanks @bbrala. I am removing other patches after #9

+++ b/core/modules/help/tests/src/Functional/HelpTest.php
@@ -101,7 +101,7 @@ public function testHelp() {
+    $list = ['BigPipe', 'Block', 'Custom Block', 'History', 'Text Editor'];

Is the addition of BigPipe here intentional? Edit: I see this was asked before, but not actually answered. Can we explain why BigPipe needs to be added?

Updated IS, patch looks good, CR exists

not sure about release notes snippet

Hey @andypost just trying to help you out here, I've created this new patch for D10 only since #24 is not applying.

Moving back to NR, to see what you think about the reroll.

Thank you, RTBC again (there's aggregator in D10)

Committed/pushed to 10.0.x and cherry-picked to 9.4.x, thanks!

Thank you! the last step is RTBC - #3270936: Deprecate Color module

I'm working on moving code

Bumping to critical as 9.4 tests are currently failing. And here's a patch with the rollback and application of #24.

As #34 said 9.4 needs this

+1 RTBC

Committed 0e319b4 and pushed to 9.4.x. Thanks!

Restoring status.