Problem/Motivation

Edit policy form doesn't indicate which policy is being edited.

Steps to reproduce

Edit a policy😃.

Proposed resolution

Add markup identifying the policy. After #3269614: Policy label is always empty for generic drupal mails we can simply print the label.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 symfony_mailer.policy-edit-label.3270407-3.patch568 bytesadamps
#3 symfony_mailer.policy-edit-label.3270407-3.patch568 bytesadamps
#2 3270407-2.patch1.55 KBlarisse

Comments

AdamPS created an issue. See original summary.

larisse’s picture

larisse commented
Status: Active » Needs review
StatusFileSize
new 3270407-2.patch1.55 KB

Hi! I created this patch.

adamps’s picture

adamps commented
Issue summary: View changes
StatusFileSize
new symfony_mailer.policy-edit-label.3270407-3.patch568 bytes
new symfony_mailer.policy-edit-label.3270407-3.patch568 bytes

I was imagining to show the label on the edit form, see new patch.

We could also do what you suggest.

  • AdamPS committed 3b4c736 on 1.x 
    Issue #3270407 by AdamPS, larisse: Indicate which policy is being edited
adamps’s picture

adamps commented
Status: Needs review » Fixed

Thanks for patch #2 I'm happy to commit that also. If you are interested in that please create a new issue and new patch.

We can copy Drupal Core for the best way to do it. Can copy one line from each of two files:

  • FilterFormatEditForm::submitForm() into PolicyEditForm
  • FilterFormatAddForm::submitForm() into PolicyAddForm

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.