Problem/Motivation

Go to the:
/admin/config/system/mailer/policy
or
/admin/config/regional/config-translation/mailer_policy

Label is always empty so it is very hard to mange your policy translations.

Steps to reproduce

Proposed resolution

When entity is empty, I suggest return subTypeLabel

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#6 symfony_mailer.policy-label.3269614-6.patch641 bytesadamps
#5 Mailer policy with entity.png28.35 KBadamps
#4 cap3.JPG76.95 KBlamp5
#4 cap2.JPG71.89 KBlamp5
#4 cap1.JPG98.52 KBlamp5
#2 symfony_mailer-3269614-2.patch570 byteslamp5

Comments

lamp5 created an issue. See original summary.

lamp5’s picture

lamp5
Primary language Polish
Location Rzeszow
commented
Status: Needs work » Needs review
StatusFileSize
new symfony_mailer-3269614-2.patch570 bytes
adamps’s picture

adamps commented
Status: Needs review » Postponed (maintainer needs more info)

I looked at /admin/config/system/mailer/policy as you suggested and I see the policies listed with type and sub-type.

Please can you explain what the problem is? Maybe provide a screenshot?

lamp5’s picture

lamp5
Primary language Polish
Location Rzeszow
commented
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new cap1.JPG98.52 KB
new cap2.JPG71.89 KB
new cap3.JPG76.95 KB

Before patching.
/admin/config/system/mailer/policy
Cap1
/admin/config/regional/config-translation/mailer_policy
Cap2

After patching/
Cap3

adamps’s picture

adamps commented
Status: Needs review » Needs work
StatusFileSize
new Mailer policy with entity.png28.35 KB

Thanks I see.

The first picture /admin/config/system/mailer/policy is correct. It is blank because your policies have no entity. If you make a policy for a contact form or a simplenews letter then you can set an entity - see my new screenshot.

I agree we should set a label. We should combine 3 parts: getTypeLabel(), getSubTypeLabel() and getEntityLabel() - without that there will be duplicates. Now it will match the 3 columns on /admin/config/system/mailer/policy. I suggest to join them together with " » " to match a breadcrumb. The 3rd one could be blank in which case don't add an arrow on the end.

adamps’s picture

adamps commented
Status: Needs work » Needs review
StatusFileSize
new symfony_mailer.policy-label.3269614-6.patch641 bytes

  • AdamPS committed 14ec3d4 on 1.x 
    Issue #3269614 by lamp5, AdamPS: Policy label is always empty for...
adamps’s picture

adamps commented
Status: Needs review » Fixed

Tested on edit/delete pages. Please can you confirm if this fixes the translations?

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.