The boundaries of modals are difficult to perceive in Claro when using a Windows high contrast theme.

This can easily be fixed with a transparent border or outline.

CommentFileSizeAuthor
#8 after-3269419-4-patch.png38.54 KBkaustab_roy
#8 before-3269419-4-patch.png36.84 KBkaustab_roy
#4 3269419-4.patch1 KBgauravvvv
Windows_11__1_-3.png91.76 KBmherchel

Comments

mherchel created an issue. See original summary.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

gauravvvv’s picture

gauravvvv commented
Status: Active » Needs review
StatusFileSize
new 3269419-4.patch1 KB

I have attached a patch for same. Please review

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work
Issue tags: +Needs Review Queue Initiative, +Needs screenshots, +Novice
nitin_lama’s picture

nitin_lama
he/him
Location India
commented
Assigned: Unassigned » nitin_lama
nitin_lama’s picture

nitin_lama
he/him
Location India
commented
Assigned: nitin_lama » Unassigned
kaustab_roy’s picture

kaustab_roy commented
StatusFileSize
new before-3269419-4-patch.png36.84 KB
new after-3269419-4-patch.png38.54 KB

patch #4 applied cleanly, The outlines can be seen in contrast high themes now.

Before patch:before patch
After patch: after patch

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Needs work » Reviewed & tested by the community
Issue tags: -Needs screenshots

CSS is straightforward and works. Screenshots look correct

  • bnjmnm committed 6654fa8e on 11.x 
    Issue #3269419 by Gauravvvv, Kaustab_Roy, mherchel: Claro: Boundary of...

  • bnjmnm committed 8f6ca50c on 10.1.x 
    Issue #3269419 by Gauravvvv, Kaustab_Roy, mherchel: Claro: Boundary of...
bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Reviewed & tested by the community » Fixed

Nice turnaround of a committable solution in under 10 comments!

Committed to 11.x and cherry picked to 10.1.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.