Problem/Motivation
Upon installing the module with workspaces enabled.
Symfony\Component\DependencyInjection\Exception\ServiceCircularReferenceException: Circular reference detected for service "workspaces_moderation.manager", path: "options_request_listener -> router.route_provider -> path_processor_manager -> workspaces_negotiator_path.path_processor_domain -> workspaces_moderation.manager -> logger.channel.workspaces -> logger.factory -> logger.raven". in Drupal\Component\DependencyInjection\Container->get() (line 143 of core/lib/Drupal/Component/DependencyInjection/Container.php).
Steps to reproduce
Install both this module and workspaces.
Issue fork raven-3269293
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
3liSorry was caused by custom code doing overriding parts of the workspace.
Comment #3
farse commentedI am getting a similar error but with "workspaces.manager"
"The website encountered an unexpected error. Try again later.
Symfony\Component\DependencyInjection\Exception\ServiceCircularReferenceException: Circular reference detected for service "workspaces.manager", path: "options_request_listener -> router.route_provider -> path_processor_manager -> path_alias.path_processor -> Drupal\path_alias\AliasManagerInterface -> path_alias.repository -> workspaces.manager -> logger.channel.workspaces -> logger.factory -> logger.raven -> symfony_mailer.override_manager -> config.manager -> Drupal\Core\Entity\EntityRepositoryInterface". in Drupal\Component\DependencyInjection\Container->get() (line 147 of core/lib/Drupal/Component/DependencyInjection/Container.php)."
This is happening with all the versions of raven compatible with D11.
I don't have any custom code modifying any workspace so am a bit stuck.
Comment #4
farse commentedFound an issue in Workspace https://www.drupal.org/project/workspace/issues/2927552
Comment #5
farse commentedthe issue for my was with symfony mailer. and raven I couldn't install the latest version so I opted to use symfony lite instead and that solved the problem.
Comment #6
vegardjo commentedOpening again, sorry if it is not the correct place. We are not using Workspace or Symfony mailer.
I get this issue in Drupal 11.2.3 after enabling Layout Builder (as a dependency of Navigation module, but I get it also after disabling Navigation, but not LB).
When clearing cache via Drush I get:
In Container.php line 147:
(we're also not using SecKit BTW)
Comment #7
mfbFor anyone seeing a circular reference, please provide steps to reproduce from a fresh install of Drupal core. This would include which contrib module(s) and how they need to be configured to reproduce the bug. (If a custom module is required to reproduce the bug, please upload or link to some example reproduce code.)
For extra bonus points you could open a merge request with a failing test :)
Comment #8
vegardjo commentedThanks, I tried a fresh version now:
composer require drupal/ravendrush en ravendrush cr-> [success] Cache rebuild complete.drush en layout_builderdrush cr->Circular reference detected for service "raven.config", path: "cache_tags.invalidator -> plugin.manager.block -> logger.channel.default -> logger.factory -> logger.raven -> raven.config -> config.factory -> raven.seckit_overrider".I'll poke around a bit more, but I'm not really grasping the full issue here I think, so don't hold your breath :)
Comment #9
vegardjo commentedCan confirm that by not injecting the config in https://git.drupalcode.org/project/raven/-/blob/7.x/src/Config/SecKitOve... (but rather reading the values directly from within loadOverrides) my issue is resolved. I will try to find some time the coming days / week to make a MR.
Comment #11
mfbPlease test the MR - I believe this should resolve the issue by refactoring config to "properly" override (rather than having a special snowflake config service).
Comment #12
vegardjo commentedThanks for your swift reaction, seems indeed like a solid solution!
I have applied the MR as a patch to both the fresh site and the original site where I first saw it, and applying it removes the error on both sites when following the process in my comment #8.
I have not tested anything more, as we don't use seckit or any overrides AFAIK, but let me know if I can be to any more assistance.
Comment #14
mfbFor future reference, this ideally would've been filed as a new issue, as it was a new bug in the 7.x branch, but in any case thanks for reporting
Comment #16
mfb@farse on the current 7.x branch I am still seeing a ServiceCircularReferenceException if I install symfony_mailer module and core workspaces_ui module along with any logger that uses config, such as core syslog module or Raven module.
Given that the issue also affects core syslog module, I would say the issue should ideally be resolved in either symfony_mailer or core?
There might be some workaround we could do in Raven module, but I'm not sure off hand what that would be, aside from no longer using config..
Comment #18
sebastixAfter upgrading raven to version 7.3.7, I got the same error.
```
Symfony\Component\DependencyInjection\Exception\ServiceCircularReferenceException: Circular reference detected for service "logger.raven", path: "options_request_listener -> router.route_provider -> cache_tags.invalidator -> plugin.manager.block -> logger.channel.default -> logger.factory -> logger.raven -> Drupal\commerce\Hook\CommerceHooks -> commerce.inbox_message_fetcher -> http_client -> http_client_factory -> GuzzleHttp\HandlerStack -> http_client_middleware.raven -> raven.request_subscriber". in Drupal\Component\DependencyInjection\Container->get() (regel 147 van /../web/core/lib/Drupal/Component/DependencyInjection/Container.php).
```
Contrib module Layout Builder was enabled (following comment #8). After uninstalling this module, the error is not there anymore.
Comment #19
mfb@sebastix Thanks for the report, please provide steps to reproduce from a clean install of Drupal core and create a new issue, or at least re-open this closed issue.
Comment #20
bobooon commented