Problem/Motivation

There are a few BC layers in constructors in the extension system that were added in Drupal 9, these can be removed in Drupal 10.

Steps to reproduce

Proposed resolution

Find and remove them.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#4 interdiff_3269153_2-4.txt5.01 KBandregp
#4 3269153-4.patch10.15 KBandregp
#2 3269153-2.patch8.67 KBlongwave
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

longwave created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Active » Needs review
FileSize
3269153-2.patch8.67 KB
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Needs review » Needs work 
+++ b/core/lib/Drupal/Core/Extension/ThemeInstaller.php
similarity index 64%
rename from core/tests/Drupal/KernelTests/Core/Extension/LegacyExtensionPathResolverTest.php

rename from core/tests/Drupal/KernelTests/Core/Extension/LegacyExtensionPathResolverTest.php
rename to core/tests/Drupal/KernelTests/Core/Extension/ExtensionPathResolverTest.php

rename to core/tests/Drupal/KernelTests/Core/Extension/ExtensionPathResolverTest.php
index 6755e4be66..b881872e46 100644

We already have Drupal\KernelTests\Core\Bootstrap\ExtensionPathResolverTest so this should probably go in there.

andregp’s picture

andregp CreditAttribution: andregp at CI&T commented
Status: Needs work » Needs review
FileSize
3269153-4.patch10.15 KB
interdiff_3269153_2-4.txt5.01 KB

Moved the test from core/tests/Drupal/KernelTests/Core/Extension/ExtensionPathResolverTest.php to core/tests/Drupal/KernelTests/Core/Bootstrap/ExtensionPathResolverTest.php

tmaiochi’s picture

tmaiochi CreditAttribution: tmaiochi at CI&T commented

I verified and tested patch #4 in Drupal 10.0x-dev version. Patch applied successfully and looks good to me. Besides that the test mentioned in #3 was moved to Drupal\KernelTests\Core\Bootstrap\ExtensionPathResolverTest as suggested. +1 RTBC!

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Needs review » Reviewed & tested by the community

Looks ready

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 4: 3269153-4.patch, failed testing. View results

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Needs work » Reviewed & tested by the community
andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Issue tags: +Deprecation Removal
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Thunder commented
Status: Reviewed & tested by the community » Fixed

Committed 4305d90 and pushed to 10.0.x. Thanks!

  • alexpott committed 4305d90 on 10.0.x 
    Issue #3269153 by andregp, longwave, catch: Remove BC layers from the...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.