Problem/Motivation

In #2927230: 3/3 JS codestyle: camelcase and related issues we converted JavaScript variable names from snake_case to camelCase. In ajax.js, element_settings was already in use so we provided a BC layer.

Steps to reproduce

Proposed resolution

Remove the BC layer.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#6 reroll_diff_3269152-2_3269152-6.txt546 bytesyogeshmpawar
#6 3269152-6.patch8.55 KByogeshmpawar
#2 3269152-2.patch8.56 KBlongwave

Comments

longwave created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review
StatusFileSize
new 3269152-2.patch8.56 KB

There are still some references to element_settings in core/modules/views/js/ajax_view[.es6].js, unclear if these need to be updated or not.

Status: Needs review » Needs work

The last submitted patch, 2: 3269152-2.patch, failed testing. View results

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs work » Needs review

Unrelated fail in JS test.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community 
+++ b/core/misc/cspell/dictionary.txt
@@ -186,7 +186,6 @@ canonicalized
 catalana
-catbro
 catchable

lol

Looks good, I had to read a couple of the removals twice to check they really were for element.settings but all looks right.

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented
StatusFileSize
new 3269152-6.patch8.55 KB
new reroll_diff_3269152-2_3269152-6.txt546 bytes

Updated patch with reroll diff attached.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Fixed 
+++ b/core/misc/cspell/dictionary.txt
@@ -186,7 +186,6 @@ canonicalized
 catalana
-catbro
 catchable

😥

Committed 189d5a8 and pushed to 10.0.x. Thanks!

  • lauriii committed 189d5a8 on 10.0.x 
    Issue #3269152 by yogeshmpawar, longwave, catch: Remove element_settings...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.