See #2915784: 1/3 JS codestyle: camelcase for more information.

This issue is just the changes to ajax module, including the BC layers and new tests.

CommentFileSizeAuthor
#7 interdiff-2927230-4-7.txt477 bytesGrandmaGlassesRopeMan
#7 2927230-7.patch44.66 KBGrandmaGlassesRopeMan
#4 interdiff-2927230-2-4.txt1.24 KBGrandmaGlassesRopeMan
#4 2927230-4.patch44.67 KBGrandmaGlassesRopeMan
#2 2927230-2.patch44.53 KBGrandmaGlassesRopeMan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

drpal created an issue. See original summary.

GrandmaGlassesRopeMan’s picture

GrandmaGlassesRopeMan
he/him
Primary language English
Location 🌎
CreditAttribution: GrandmaGlassesRopeMan at Acquia commented
FileSize
2927230-2.patch44.53 KB
GrandmaGlassesRopeMan’s picture

GrandmaGlassesRopeMan
he/him
Primary language English
Location 🌎
CreditAttribution: GrandmaGlassesRopeMan at Acquia commented
Status: Active » Needs review
GrandmaGlassesRopeMan’s picture

GrandmaGlassesRopeMan
he/him
Primary language English
Location 🌎
CreditAttribution: GrandmaGlassesRopeMan at Acquia commented
FileSize
2927230-4.patch44.67 KB
interdiff-2927230-2-4.txt1.24 KB

- Additional test docs, thanks @dawehner.

The last submitted patch, 2: 2927230-2.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 4: 2927230-4.patch, failed testing. View results

GrandmaGlassesRopeMan’s picture

GrandmaGlassesRopeMan
he/him
Primary language English
Location 🌎
CreditAttribution: GrandmaGlassesRopeMan at Acquia commented
Status: Needs work » Needs review
FileSize
2927230-7.patch44.66 KB
interdiff-2927230-4-7.txt477 bytes

- fixed the duplicate description key.

mikejw’s picture

mikejw CreditAttribution: mikejw at University of Adelaide commented
Status: Needs review » Reviewed & tested by the community

As per 1/3 I ran the yarn lint command and there were no errors re ajax.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick at Acquia commented
Status: Reviewed & tested by the community » Postponed

Since this one turns on the rule checking, I don't think it can be committed until the other two are in, so marking (temporarily) postponed.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented

Can we also format the deprecation message in the standard format? Thanks!

https://www.drupal.org/core/deprecation

webchick credited dawehner.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick at Acquia commented
Status: Postponed » Fixed

Switched to the following:

Angies-MBP:core angie.byron$ git diff
diff --git a/core/misc/ajax.es6.js b/core/misc/ajax.es6.js
index 8cce3329bc..095154ad8b 100644
--- a/core/misc/ajax.es6.js
+++ b/core/misc/ajax.es6.js
@@ -388,7 +388,8 @@
     this.element = element;
 
     /**
-     * @deprecated See elementSettings.
+     * @deprecated in Drupal 8.0.0 and will be removed before Drupal 9.0.0.
+     * Use elementSettings.
      *
      * @type {Drupal.Ajax~elementSettings}
      */

...also fixed:

/Users/angie.byron/Sites/8.x/core/modules/system/tests/modules/js_ajax_test/js/js_ajax_test.ajax.es6.js
   6:23  error  Block must not be padded by blank lines  padded-blocks
  30:1   error  Block must not be padded by blank lines  padded-blocks

...by removing some newlines.

...and committed/pushed to 8.5.x. w00t!

  • webchick committed 8d06691 on 8.5.x 
    Issue #2927230 by drpal, dawehner: 3/3 JS codestyle: camelcase
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick at Acquia commented

Also fired up a change record for us to keep track of these and other ESLint changes: https://www.drupal.org/node/2928117

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented

Hm, this was not deprecated in 8.0.0... it was deprecated in 8.5.0?

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner at Chapter Three commented
Related issues: +#2928137: Correct deprecation note in ajax.es6.js

Well maybe @webchick has time traveling capabilities :P
I added some quick follow up novice task: #2928137: Correct deprecation note in ajax.es6.js

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented
Issue tags: -JavaScript +JavaScript

publish change record