Currently visitors tries to get the title directly from the routeObject. This doesn't work on some pages, such as /admin/reports/dblog.
Enable the module and visit the database log page. Check the "visitors" table in the database and see there is no title for the entry.
Use the title_resolver service to get the title.
Reference: drupal_set_title() and drupal_get_title() were removed.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | use_title_resolver-3268967-10.patch | 800 bytes | sah62 |
| #2 | use_title_resolver-3268967-2.patch | 700 bytes | imclean |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
imclean commentedThis should probably be injected but there are a few other \Drupal calls so they could all be fixed in the one issue.
Comment #3
imclean commentedComment #7
bluegeek9 commentedComment #8
sah62 commentedThere's actually an issue with this fix: \Drupal::service('title_resolver')->getTitle can return an array, and you can't pass an array to htmlspecialchars_decode().
Comment #9
bluegeek9 commentedGood catch. if the result is an array, the '#markup' index should be used.
Comment #10
sah62 commentedHere's a proposed patch. getTitle can also return null, so I thought it best to test the return value to see if it's a string, or an array, and then return an empty string if it isn't a string or an array.
Comment #12
bluegeek9 commentedI added the is_array check. The is_string check is redundant.
Comment #13
bluegeek9 commentedComment #15
bluegeek9 commented