Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
The changes required for 'Drupal.Commenting.DocComment.ShortSingleLine' are too large and need to be split into child issues.
Proposed resolution
Fix class doc block in non test files for the sniff 'Drupal.Commenting.DocComment.ShortSingleLine'.
Remaining tasks
Patch
Review - Instructions for adding the sniff and running the test are in the Issue Summary of #3123060: Enable 'Drupal.Commenting.DocComment.ShortSingleLine' coding standard
Commit
User interface changes
API changes
Data model changes
Release notes snippet
Comment | File | Size | Author |
---|---|---|---|
#5 | reroll_diff_2-5.txt | 8.78 KB | ravi.shankar |
#5 | 3268818-5.patch | 27.22 KB | ravi.shankar |
| |||
#2 | 3268818-2.patch | 30.5 KB | quietone |
|
Comments
Comment #2
quietone CreditAttribution: quietone at PreviousNext commentedComment #3
Shashwat Purav CreditAttribution: Shashwat Purav at Portage CyberTech for Drupal Association commentedThe patch in #2 applied successfully to 10.0.x branch.
Comment #4
quietone CreditAttribution: quietone at PreviousNext commentedTime for a reroll
Comment #5
ravi.shankar CreditAttribution: ravi.shankar at OpenSense Labs commentedAdded reroll of patch #2 on Drupal 10.0.x.
Removed needs reroll tag as well.
Comment #6
smustgrave CreditAttribution: smustgrave at Mobomo commentedBrought this up on slack and since this still cleanly applies to 10.1 good to mark RTBC.
If any additional work is needed I will help keep an eye out for any tweaks needed.
Comment #7
alexpottCommitted and pushed eec3210128 to 10.1.x and f8144f44e2 to 10.0.x and 98b21491b4 to 9.5.x and c9f75473d4 to 9.4.x. Thanks!
Backported to 9.4.x as this is only minimal docs changes.