Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
10 Mar 2022 at 04:01 UTC
Updated:
11 Jul 2022 at 15:34 UTC
Jump to comment: Most recent
Comments
Comment #2
avpadernoThank you for applying! Reviewers will check the project files and report what should be changed.
Comment #3
geoanders commented@bbeversdorf
You might want to review your branches and make sure they conform to the Drupal standard:
https://www.drupal.org/docs/develop/git/git-for-drupal-project-maintaine...
You might want to add a composer.json file to your project as well:
https://www.drupal.org/docs/creating-custom-modules/add-a-composerjson-file
Ran a quick coding standards scan. See results below:
Comment #4
geoanders commentedComment #5
bbeversdorf commented@geoanders
For branch names I followed the pattern for D8 or later.
I have added a composer.json and addressed the warnings.
Comment #6
bbeversdorf commentedComment #7
avpadernoYes, 1.0.x is a correct branch name. It's accepted now that projects are allowed to use semantic versioning.
main isn't a branch name that should be used for release branches. For how it's used, it needs to be removed too.
Comment #8
avpadernoComment #9
bbeversdorf commented@apaderno Understood. I have removed the main branch.
Comment #10
bbeversdorf commentedComment #11
avpadernoThank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:
You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
I thank all the dedicated reviewers as well.
Comment #14
avpadernoI am crediting the user who closed the other application. I apologize for bumping this application.