This module adds an endpoint 'oauth\revoke' method to the site to give the ability for users to revoke their token and log out. It is to be used with the Simple Oauth module.

Project link

https://www.drupal.org/project/simple_oauth_revoke

Git instructions

git clone --branch '1.0.x' https://git.drupalcode.org/project/simple_oauth_revoke.git

Comments

bbeversdorf created an issue. See original summary.

avpaderno’s picture

Issue summary: View changes

Thank you for applying! Reviewers will check the project files and report what should be changed.

geoanders’s picture

@bbeversdorf

You might want to review your branches and make sure they conform to the Drupal standard:
https://www.drupal.org/docs/develop/git/git-for-drupal-project-maintaine...

You might want to add a composer.json file to your project as well:
https://www.drupal.org/docs/creating-custom-modules/add-a-composerjson-file

Ran a quick coding standards scan. See results below:

FILE: /simple_oauth_revoke/simple_oauth_revoke.routing.yml
-----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
 7 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
-----------------------------------------------------------------------------------------------------------------

FILE: /simple_oauth_revoke/simple_oauth_revoke.info.yml
---------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------
 1 | WARNING | "core_version_requirement" property is missing in the info.yml file
---------------------------------------------------------------------------------------------

FILE: /simple_oauth_revoke/README.md
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 3 | WARNING | Line exceeds 80 characters; contains 127 characters
--------------------------------------------------------------------------
geoanders’s picture

Status: Needs review » Needs work
bbeversdorf’s picture

@geoanders

For branch names I followed the pattern for D8 or later.

for projects compatible with the latest versions of Drupal 8 and later, the format can be {major}.x or {major}.{minor}.x

I have added a composer.json and addressed the warnings.

bbeversdorf’s picture

Status: Needs work » Needs review
avpaderno’s picture

Yes, 1.0.x is a correct branch name. It's accepted now that projects are allowed to use semantic versioning.

main isn't a branch name that should be used for release branches. For how it's used, it needs to be removed too.

avpaderno’s picture

Status: Needs review » Needs work
bbeversdorf’s picture

@apaderno Understood. I have removed the main branch.

bbeversdorf’s picture

Status: Needs work » Needs review
avpaderno’s picture

Assigned: Unassigned » avpaderno
Status: Needs review » Fixed

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

apaderno credited cmlara.

avpaderno’s picture

Status: Closed (fixed) » Fixed

I am crediting the user who closed the other application. I apologize for bumping this application.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.