Test all the properties included in the response, like breadcrumbs, metatags, layout etc.
Example of how to perform get request and check response data can be found in LupusCeRendererContentTest::testDefaultContentFormat()

CommentFileSizeAuthor
#7 3267729-7-api-data-tests.patch2.74 KBciprian.stavovei
#4 3267729-4-api-data-tests.patch2.8 KBciprian.stavovei
#2 3267729-2-api-data-tests.patch2.99 KBciprian.stavovei

Comments

mostepaniukvm created an issue. See original summary.

ciprian.stavovei’s picture

ciprian.stavovei commented
Status: Active » Needs review
StatusFileSize
new 3267729-2-api-data-tests.patch2.99 KB
fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Needs work

test case looks mostly good, but i don't think mink expectation exceptions should be used from within phpunit. it would probably work as an exception woudl break it, but it'S not the proper way of failing a test in phpunit.

check https://api.drupal.org/api/drupal/vendor%21phpunit%21phpunit%21src%21Fra... and related assertoin helpers.

ciprian.stavovei’s picture

ciprian.stavovei commented
StatusFileSize
new 3267729-4-api-data-tests.patch2.8 KB

I updated the patch according to feedback.

ciprian.stavovei’s picture

ciprian.stavovei commented
Status: Needs work » Needs review
mostepaniukvm’s picture

mostepaniukvm
he/him
commented
Status: Needs review » Needs work

@ciprian.stavovei looks good now. Minor fixes needed for indentation, phpcs is not happy

ciprian.stavovei’s picture

ciprian.stavovei commented
Status: Needs work » Needs review
StatusFileSize
new 3267729-7-api-data-tests.patch2.74 KB

Fixed the phpcs issues.

mostepaniukvm’s picture

mostepaniukvm
he/him
commented
Status: Needs review » Fixed

@ciprian.stavovei looks good now, committed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.