Problem/Motivation

Deprecate aggregator

Steps to reproduce

Proposed resolution

Remaining tasks

Add section for aggregator to Recommendations for deprecated modules
Add @group to the REST tests

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#14 1916+1986.diff43.65 KBspokje
#13 1916+1986.diff43.65 KBspokje

Issue fork drupal-3267458

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

quietone created an issue. See original summary.

quietone’s picture

Issue summary: View changes

Just making a start.

yogeshmpawar made their first commit to this issue’s fork.

Spokje made their first commit to this issue’s fork.

spokje’s picture

Title: Deprecate aggregator module in Drupal 9.4 » [PP-1] Deprecate aggregator module in Drupal 9.4

We've hit another postponing snag: https://dispatcher.drupalci.org/job/drupal_patches/120235/testReport/jun...

Modules which are deprecated are still testing for valid config routes, thus triggering the deprecation warning, making TestBot sad.

Let's try to make the poor fellow happy again in #3270323: ModuleConfigureRouteTest::testModuleConfigureRoutes fails for modules which have a configure route and are deprecated

Postponing this issue on the above.

spokje’s picture

Status: Active » Postponed
catch’s picture

Status: Postponed » Needs review

murilohp made their first commit to this issue’s fork.

murilohp’s picture

Just rebased to let the branch mergeable.

murilohp’s picture

I don't know who put the test to run again, but unfortunately it already failed on core/tests/Drupal/KernelTests/Core/Extension/ModuleConfigureRouteTest.php due to the deprecation notices, just check: https://dispatcher.drupalci.org/job/drupal_patches/120663/consoleText (use Ctr+f and search for ModuleConfigureRouteTest)

spokje’s picture

Status: Needs review » Postponed

Re-postponing on #3270323: ModuleConfigureRouteTest::testModuleConfigureRoutes fails for modules which have a configure route and are deprecated, since the previous "fix" was one of those "Too Good To Be True"-deals... :/

spokje’s picture

StatusFileSize
new43.65 KB
spokje’s picture

StatusFileSize
new43.65 KB
spokje’s picture

spokje’s picture

Title: [PP-1] Deprecate aggregator module in Drupal 9.4 » Deprecate aggregator module in Drupal 9.4
Status: Postponed » Needs review
spokje’s picture

Status: Needs review » Reviewed & tested by the community
spokje’s picture

Status: Reviewed & tested by the community » Needs review

Restoring unwanted status change

spokje’s picture

The only question that remains for me:

Should this MR also contain the changed fixture drupal.9.3.0.filled.standard.php of #3264120: Remove aggregator module and our dependency on Laminas Feed to keep 9.4.x and 10.0.x in sync?

catch’s picture

I think we actually want to leave it the same in 9.4, because that fixture will test any aggregator updates in 9.4 etc.

So the 10.x fixture ends up being an updated/slimmed down version of the 9.4 fixture.

spokje’s picture

Thanks @catch, sense = made.

I looked it up in #3263618: Deprecate HAL module and for the deprecation of hal we also didn't change the fixture, so we're even consistent :)

bbrala’s picture

Status: Needs review » Reviewed & tested by the community

Checked the code. Seems complete and the tests are green. This is rtbc for me.

Also removing credit for the random rebase.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 559ddbd and pushed to 9.4.x. Thanks!

  • alexpott committed 559ddbd on 9.4.x
    Issue #3267458 by Spokje, quietone, yogeshmpawar, catch: Deprecate...
niklan’s picture

Hi, folks.

Change record for that issue has a link «recommendations for Aggregator» that directs to: https://www.drupal.org/docs/core-modules-and-themes/deprecated-and-obsol...

  1. The anchor is wrong and directs to HAL module section.
  2. There is no information about Aggregator replacement.

At this point, this link is misleading and confusing.

UPD. Sorry, found that change records have their own comment system. Since I'm already pinged people here with this update, can someone to clarify and update change record? Does Aggregator have replacements or not?

catch’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.