Closed (fixed)
Project:
Drupal core
Version:
9.4.x-dev
Component:
aggregator.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
2 Mar 2022 at 22:29 UTC
Updated:
12 Apr 2022 at 14:49 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #3
quietone commentedJust making a start.
Comment #6
spokjeWe've hit another postponing snag: https://dispatcher.drupalci.org/job/drupal_patches/120235/testReport/jun...
Modules which are deprecated are still testing for valid config routes, thus triggering the deprecation warning, making TestBot sad.
Let's try to make the poor fellow happy again in #3270323: ModuleConfigureRouteTest::testModuleConfigureRoutes fails for modules which have a configure route and are deprecated
Postponing this issue on the above.
Comment #7
spokjeComment #8
catchComment #10
murilohp commentedJust rebased to let the branch mergeable.
Comment #11
murilohp commentedI don't know who put the test to run again, but unfortunately it already failed on
core/tests/Drupal/KernelTests/Core/Extension/ModuleConfigureRouteTest.phpdue to the deprecation notices, just check: https://dispatcher.drupalci.org/job/drupal_patches/120663/consoleText (use Ctr+f and search for ModuleConfigureRouteTest)Comment #12
spokjeRe-postponing on #3270323: ModuleConfigureRouteTest::testModuleConfigureRoutes fails for modules which have a configure route and are deprecated, since the previous "fix" was one of those "Too Good To Be True"-deals... :/
Comment #13
spokjeComment #14
spokjeComment #15
spokjeComment #16
spokjeRe-unpostponing after the re-fix of #3270323: ModuleConfigureRouteTest::testModuleConfigureRoutes fails for modules which have a configure route and are deprecated re-landed...
Comment #17
spokjeComment #18
spokjeRestoring unwanted status change
Comment #19
spokjeThe only question that remains for me:
Should this MR also contain the changed fixture
drupal.9.3.0.filled.standard.phpof #3264120: Remove aggregator module and our dependency on Laminas Feed to keep 9.4.x and 10.0.x in sync?Comment #20
catchI think we actually want to leave it the same in 9.4, because that fixture will test any aggregator updates in 9.4 etc.
So the 10.x fixture ends up being an updated/slimmed down version of the 9.4 fixture.
Comment #21
spokjeThanks @catch, sense = made.
I looked it up in #3263618: Deprecate HAL module and for the deprecation of hal we also didn't change the fixture, so we're even consistent :)
Comment #22
bbralaChecked the code. Seems complete and the tests are green. This is rtbc for me.
Also removing credit for the random rebase.
Comment #23
alexpottCommitted 559ddbd and pushed to 9.4.x. Thanks!
Comment #25
niklanHi, folks.
Change record for that issue has a link «recommendations for Aggregator» that directs to: https://www.drupal.org/docs/core-modules-and-themes/deprecated-and-obsol...
At this point, this link is misleading and confusing.
UPD. Sorry, found that change records have their own comment system. Since I'm already pinged people here with this update, can someone to clarify and update change record? Does Aggregator have replacements or not?
Comment #26
catchFixed the CR and the docs page
https://www.drupal.org/docs/core-modules-and-themes/deprecated-and-obsol...