Postponed on #3194084: Support functionality equivalent to ckeditor_stylesheets

Problem/Motivation

In #3194084: Support functionality equivalent to ckeditor_stylesheets, a new ckeditor5-stylesheets theme configuration was created. It provides functionality similar to ckeditor_stylesheets, but exists as a separate settings as there are scenarios where a stylesheet that works well in CKEditor 4 won't necessarily work well in CKEditor 5.

Since this theme has ckeditor_stylesheets configured, it should get a ckeditor5-stylesheets setting. It may be possible to use the same stylesheets, but manual testing will be required to confirm the styling is desirable and doesn't have side effects. This is especially necessary as CKEditor5 stylesheets are not encapsulated in an <iframe>

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#6 bartik-ckeditor5-stylesheets-3267435.6.patch369 bytesmashir

Issue fork bartik-3267435

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bnjmnm created an issue. See original summary.

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Title: [PP-1] Add ckeditor5-stylesheets config » [PP-1] Add Bartik ckeditor5-stylesheets config

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone commented
Project: Drupal core » Bartik
Version: 10.1.x-dev » 1.0.2
Component: Bartik theme » Look and Feel

Bartik has been removed from core. This looks like it should be in the contrib project.

mashir’s picture

mashir commented
Status: Active » Needs review
StatusFileSize
new bartik-ckeditor5-stylesheets-3267435.6.patch369 bytes

Here is the patch we need to apply to remove the warnings from Text Formatter section.

solideogloria’s picture

solideogloria commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +ckeditor5

The patch does remove the warnings for me when I applied the patch.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Version: 1.0.2 » 1.0.x-dev
Status: Reviewed & tested by the community » Needs work

Please put the patch into an issue fork and merge request.

solideogloria opened merge request !12

solideogloria’s picture

solideogloria commented
Status: Needs work » Needs review
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Title: [PP-1] Add Bartik ckeditor5-stylesheets config » Add Bartik ckeditor5-stylesheets config
solideogloria’s picture

solideogloria commented
Status: Needs review » Reviewed & tested by the community

I've been using this successfully for a couple years now.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Version: 1.0.x-dev » 1.1.x-dev

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Thanks

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.