Closed (fixed)
Project:
WebP
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
1 Mar 2022 at 13:24 UTC
Updated:
29 Aug 2023 at 09:09 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
vannergard commentedComment #3
vannergard commentedComment #4
vannergard commentedAnd here is the patch I used to work around the warning. As mentioned not sure how secure it is, but it runs the same code as before but without warning.
Comment #5
vannergard commentedTo be clear this issue seems to not have any functional effect, but it makes logs harder to read and is an general annoyance
Comment #6
jedgar1mx commentedI see this error too. In some of our cases it looks like the image style that the module it's trying to serve is missing. So maybe just having a more friendly way to exit out in case of missing file. I edited the first patch a bit and now I get
Error generating image, missing source file.message instead of the siteTemporarily Unavailablemessage.Comment #7
avpadernoComment #8
zcht commentedSince the switch to PHP 8.1 I had the same error, patch #6 fixed it successfully in my case.
Comment #9
gaele commentedRTBC for #6.
Comment #10
basvredelingPatch #6 doesn't adhere to the Drupal code style. Needs a slight update.
Comment #11
gaele commented@jedgar1mx see https://www.drupal.org/docs/develop/standards/coding-standards
Comment #12
arccoss commentedMade some fixes on the formatting of #6. Now it should be ok.
Comment #13
basvredeling#12 looks good, status back to RTBC
Comment #14
basvredelingPatch #12 didn't apply via composer patching. New patch also fixes bad code style (tabs) in next few lines.
Comment #15
avpadernoThere is no need to use a
tryblock. It's sufficient to avoid to passNULLtohash_equals().For changing the code to follow the coding standards, a new issue is required.
Comment #16
basvredelingNew patch with feedback from #15 included.
Comment #17
godotislateThe logic in the controller can probably otherwise be streamlined a bit, but I think this patch addresses the issue and has the smallest diff.
Comment #18
berliner commentedPatch in #17 applies properly and solves the error.
Comment #19
odai atiehPatch #17 solved the issue
Comment #20
ahmad abbad commented+1 patch#17
Comment #21
gaele commentedComment #22
idiaz.roncero+1, Patch 17 solves the issue.
Comment #23
eduardo morales albertiPatch #17 solved the issue
Comment #24
klemendev commentedLooks good (patch #17 fixes the issue), hope this gets into a release soon :)
Comment #25
angelgarciaco commentedWell .. patch #17 what do we could have done without you? :D
Comment #26
nicxvan commented17 is required for me or the site fails, adding 17 works though!
Comment #27
klemendev commented@mandclu asked for confirmations of open issues on #3290669 so we can get a new stable release, so here is another confirmation this is RTBC and working on our websites :)
Comment #28
klemendev commentedI can confirm again #17 works fine on multiple production sites and this issue seems RTBC and for release
Comment #30
mandclu commentedThanks to all for the various patches, as well as feedback on the patch in #17. Merged in, and will roll a release shortly.