See https://www.drupal.org/node/380866/qa => e.g. https://www.drupal.org/pift-ci-job/2329465

CommentFileSizeAuthor
#9 coding-standard-fix-3266906-9.patch28.52 KBakshaydalvi212
#7 interdiff_5-7.txt3.05 KBmrinalini9
#7 coding-standard-fix-3266906-7.patch27.93 KBmrinalini9
#5 coding-standard-fix-3266906-5.patch27.88 KBurvashi_vora

Issue fork homebox-3266906

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Grevil created an issue. See original summary.

  • Anybody committed 975549a on 3.0.x 
    Issue #3266906: Fix coding standard issues for 3.x
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Title: Fix coding standard issues for 3.x » Fix coding standard issues
Version: 2.0.x-dev » 3.0.x-dev
Issue summary: View changes
Status: Active » Needs work
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Issue summary: View changes
urvashi_vora’s picture

urvashi_vora commented
Status: Needs work » Needs review
StatusFileSize
new coding-standard-fix-3266906-5.patch27.88 KB

Hi
Please review this patch.

Thanks

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Needs work

@urvashi_vora see https://www.drupal.org/pift-ci-job/2400618

mrinalini9’s picture

mrinalini9 commented
Status: Needs work » Needs review
StatusFileSize
new coding-standard-fix-3266906-7.patch27.93 KB
new interdiff_5-7.txt3.05 KB

Fixed PHPLint and some other whitespace issues in patch #5, please review it.

Status: Needs review » Needs work

The last submitted patch, 7: coding-standard-fix-3266906-7.patch, failed testing. View results

akshaydalvi212’s picture

akshaydalvi212 commented
Assigned: Unassigned » akshaydalvi212
StatusFileSize
new coding-standard-fix-3266906-9.patch28.52 KB

Hello,
kindly check the patch and provide your feedback on the same.

Thanks and Regards.

akshaydalvi212’s picture

akshaydalvi212 commented
Assigned: akshaydalvi212 » Unassigned
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 9: coding-standard-fix-3266906-9.patch, failed testing. View results

Grevil opened merge request !7

Grevil opened merge request !8

Grevil closed merge request !8

grevil’s picture

grevil commented
Status: Needs work » Reviewed & tested by the community

Sry for the mess... Everything is looking great. Last failing test is unrelated to this issue.

  • Anybody committed 3d3581b on 3.0.x authored by Grevil 
    Issue #3266906 by Grevil, mrinalini9, akshaydalvi212, urvashi_vora,...
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Fixed

Thanks, merged!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.