Problem/Motivation

As discussed at #2758203: No permissions? for Drupal 7, this module needs permissions so that the setting is not exposed to all content editors.

CommentFileSizeAuthor
#6 without-permission.png20.19 KBArturo-q
#6 with-permission.png30.96 KBArturo-q
#5 node_class-3266541-4.patch1.17 KBjustskew
#3 node_class-3266541-3.patch1.34 KBrobcarr
#2 node_class-3266541-2.patch1.41 KBrobcarr

Issue fork node_class-3266541

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

robcarr created an issue. See original summary.

robcarr’s picture

robcarr
Primary language English
Location Perthshire, Scotland
commented
Status: Active » Needs review
StatusFileSize
new node_class-3266541-2.patch1.41 KB

Patch attached

robcarr’s picture

robcarr
Primary language English
Location Perthshire, Scotland
commented
StatusFileSize
new node_class-3266541-3.patch1.34 KB

Sorry - was in a hurry to post last patch. This one applies correctly.

robcarr’s picture

robcarr
Primary language English
Location Perthshire, Scotland
commented
Status: Needs review » Needs work

Permissions not working correctly

justskew’s picture

justskew commented
Status: Needs work » Needs review
StatusFileSize
new node_class-3266541-4.patch1.17 KB

Fixed

Arturo-q’s picture

Arturo-q commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new with-permission.png30.96 KB
new without-permission.png20.19 KB

Hi, I've reviewed patch #4, and it fixes the issue, I've tested it locally and now the "Node class setting" tab only appears on the edit node page if the actual user has the new role "Define custom node classes", moving to RTBC.
Regards.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Version: 2.0.0 » 2.0.x-dev
Status: Reviewed & tested by the community » Needs work

Please use a MR instead.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Priority: Normal » Major

This is a very helpful and important feature.

vitaliyb98 made their first commit to this issue’s fork.

vitaliyb98 opened merge request !5

vitaliyb98’s picture

vitaliyb98 commented
Status: Needs work » Reviewed & tested by the community

Hi, added changes from the patch into the MR. Tested it, works as expected, moved to RTBC

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Needs work

Thanks @vitaliyb98 - as this is quite widely used, please add an (empty) update hook that informs user about the new permission in its PHPDoc, so they will see the message when updating. Let them know what to do, as this is a breaking change.

vitaliyb98’s picture

vitaliyb98 commented
Status: Needs work » Needs review

Hi @anybody, thanks for your feedback!

Added hook update with:

/**
 * New permission "Define custom node classes" was introduced.
 *
 * Breaking change: only users with this permission can manage
 * node class settings. Please assign it to appropriate roles.
 */

If you have a better idea for the text, please let me know)

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Reviewed & tested by the community

Thanks @vitaliyb98 I think it's good enough.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.