[D9] Animated Scroll To [#3266509]

The Animated Scroll To module provides the possibility to easily scroll to elements on pages. It uses anchor links to scroll (with a configurable animation) to the correct element. It doesn't matter if the element is on the same page (like with a link like "#anchor") or that the element is on another page (like "/node/4#anchor). It differs from other (similar) modules by the fact that it is possible to "chain" anchors in the link and that it is possible (but not required) to configure the speed, pause, correction and easing per element. More about chaining multiple anchors and configuration per element is explained on the project page.

Project link

https://www.drupal.org/project/animated_scroll_to

Git instructions

git clone --branch '8.x-1.x' https://git.drupalcode.org/project/animated_scroll_to.git

Comment	File	Size	Author
	animated-scroll-to-settings.png	120.89 KB	ewout goosmann
	animated-scroll-to-demo.gif	29.08 MB	ewout goosmann

Comments

Comment #1

25 February 2022 at 10:38

Ewout Goosmann created an issue. See original summary.

Comment #2

ewout goosmann

Dutch

commented 25 February 2022 at 10:41

Issue summary:

View changes

Comment #3

avpaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

commented 25 February 2022 at 14:07

Issue tags:

+PAreview: single application approval

Comment #4

geoanders commented 1 March 2022 at 14:31

Ran a quick standards scan. See results below:

FILE: /animated_scroll_to/src/Form/AnimatedScrollToForm.php
-------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------
 83 | WARNING | #options values usually have to run through t() for translation
 84 | WARNING | #options values usually have to run through t() for translation
-------------------------------------------------------------------------------------------------

FILE: /animated_scroll_to/animated_scroll_to.module
-----------------------------------------------------------------------------------------
FOUND 29 ERRORS AND 2 WARNINGS AFFECTING 15 LINES
-----------------------------------------------------------------------------------------
  1 | ERROR   | [x] Missing file doc comment
  7 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  7 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 1
  8 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  8 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 1
 10 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
 10 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 1
 12 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
 12 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 2
 13 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
 13 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 2
 15 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
 15 | WARNING | [ ] Line exceeds 80 characters; contains 92 characters
 15 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 2
 16 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
 16 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 2
 17 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
 17 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 1
 19 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
 19 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 1
 21 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
 21 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 2
 22 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
 22 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 2
 24 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
 24 | WARNING | [ ] Line exceeds 80 characters; contains 92 characters
 24 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 2
 25 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
 25 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 2
 26 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
 26 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 1
-----------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 29 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------


FILE: /animated_scroll_to/src/Form/AnimatedScrollToForm.php
--------------------------------------------------------------------------------------------------------
FOUND 229 ERRORS AND 1 WARNING AFFECTING 107 LINES
--------------------------------------------------------------------------------------------------------
   3 | ERROR   | [x] Namespaced classes, interfaces and traits should not begin with a file doc comment
  10 | WARNING | [x] Unused use statement
  15 | ERROR   | [x] Missing class doc comment
  17 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  17 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 1
  18 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  19 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  20 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  20 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 1
  21 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  21 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 2
  22 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  22 | ERROR   | [x] Line indented incorrectly; expected at least 4 spaces, found 3
  22 | ERROR   | [x] Array indentation error, expected 4 spaces but found 3
  23 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  24 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  24 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 1
  26 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  26 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 1
  27 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  28 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  29 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  29 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 1
  30 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  30 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 2
  31 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  31 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 1
  33 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  33 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 1
  34 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  35 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  36 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  36 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 1
  37 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  37 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 2
  39 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  39 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 2
  40 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  40 | ERROR   | [x] Line indented incorrectly; expected at least 4 spaces, found 3
  40 | ERROR   | [x] Array indentation error, expected 4 spaces but found 3
  41 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  41 | ERROR   | [x] Line indented incorrectly; expected at least 4 spaces, found 3
  41 | ERROR   | [x] Array indentation error, expected 4 spaces but found 3
  42 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  44 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  44 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 2
  45 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  45 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 2
  46 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  46 | ERROR   | [x] Line indented incorrectly; expected at least 4 spaces, found 3
  46 | ERROR   | [x] Array indentation error, expected 4 spaces but found 3
  47 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  47 | ERROR   | [x] Line indented incorrectly; expected at least 4 spaces, found 3
  47 | ERROR   | [x] Array indentation error, expected 4 spaces but found 3
  48 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  48 | ERROR   | [x] Line indented incorrectly; expected at least 4 spaces, found 3
  48 | ERROR   | [x] Array indentation error, expected 4 spaces but found 3
  49 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  49 | ERROR   | [x] Line indented incorrectly; expected at least 4 spaces, found 3
  49 | ERROR   | [x] Array indentation error, expected 4 spaces but found 3
  50 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  52 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  52 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 2
  53 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  53 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 2
  54 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  54 | ERROR   | [x] Line indented incorrectly; expected at least 4 spaces, found 3
  54 | ERROR   | [x] Array indentation error, expected 4 spaces but found 3
  55 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  55 | ERROR   | [x] Line indented incorrectly; expected at least 4 spaces, found 3
  55 | ERROR   | [x] Array indentation error, expected 4 spaces but found 3
  56 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  56 | ERROR   | [x] Line indented incorrectly; expected at least 4 spaces, found 3
  56 | ERROR   | [x] Array indentation error, expected 4 spaces but found 3
  57 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  57 | ERROR   | [x] Line indented incorrectly; expected at least 4 spaces, found 3
  57 | ERROR   | [x] Array indentation error, expected 4 spaces but found 3
  58 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  60 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  60 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 2
  61 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  61 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 2
  62 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  62 | ERROR   | [x] Line indented incorrectly; expected at least 4 spaces, found 3
  62 | ERROR   | [x] Array indentation error, expected 4 spaces but found 3
  63 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  63 | ERROR   | [x] Line indented incorrectly; expected at least 4 spaces, found 3
  63 | ERROR   | [x] Array indentation error, expected 4 spaces but found 3
  64 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  64 | ERROR   | [x] Line indented incorrectly; expected at least 4 spaces, found 3
  64 | ERROR   | [x] Array indentation error, expected 4 spaces but found 3
  65 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  65 | ERROR   | [x] Line indented incorrectly; expected at least 4 spaces, found 3
  65 | ERROR   | [x] Array indentation error, expected 4 spaces but found 3
  66 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  68 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  68 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 2
  69 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  69 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 2
  70 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  70 | ERROR   | [x] Line indented incorrectly; expected at least 4 spaces, found 3
  70 | ERROR   | [x] Array indentation error, expected 4 spaces but found 3
  71 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  71 | ERROR   | [x] Line indented incorrectly; expected at least 4 spaces, found 3
  71 | ERROR   | [x] Array indentation error, expected 4 spaces but found 3
  72 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  72 | ERROR   | [x] Line indented incorrectly; expected at least 4 spaces, found 3
  72 | ERROR   | [x] Array indentation error, expected 4 spaces but found 3
  73 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  73 | ERROR   | [x] Line indented incorrectly; expected at least 4 spaces, found 3
  73 | ERROR   | [x] Array indentation error, expected 4 spaces but found 3
  74 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  76 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  76 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 2
  77 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  77 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 2
  78 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  78 | ERROR   | [x] Line indented incorrectly; expected at least 4 spaces, found 3
  78 | ERROR   | [x] Array indentation error, expected 4 spaces but found 3
  79 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  79 | ERROR   | [x] Line indented incorrectly; expected at least 4 spaces, found 3
  79 | ERROR   | [x] Array indentation error, expected 4 spaces but found 3
  80 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  80 | ERROR   | [x] Line indented incorrectly; expected at least 4 spaces, found 3
  80 | ERROR   | [x] Array indentation error, expected 4 spaces but found 3
  81 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  81 | ERROR   | [x] Line indented incorrectly; expected at least 4 spaces, found 3
  81 | ERROR   | [x] Array indentation error, expected 4 spaces but found 3
  82 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  82 | ERROR   | [x] Line indented incorrectly; expected at least 4 spaces, found 3
  82 | ERROR   | [x] Array indentation error, expected 4 spaces but found 3
  83 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  83 | ERROR   | [x] Array indentation error, expected 5 spaces but found 4
  84 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  84 | ERROR   | [x] Array indentation error, expected 5 spaces but found 4
  85 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  86 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  88 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  88 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 2
  89 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  89 | ERROR   | [x] Line indented incorrectly; expected at least 4 spaces, found 3
  89 | ERROR   | [x] Array indentation error, expected 4 spaces but found 3
  90 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  90 | ERROR   | [x] Line indented incorrectly; expected at least 4 spaces, found 3
  90 | ERROR   | [x] Array indentation error, expected 4 spaces but found 3
  91 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  93 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  93 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 2
  94 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  94 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 2
  95 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  95 | ERROR   | [x] Line indented incorrectly; expected at least 4 spaces, found 3
  95 | ERROR   | [x] Array indentation error, expected 4 spaces but found 3
  96 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  96 | ERROR   | [x] Line indented incorrectly; expected at least 4 spaces, found 3
  96 | ERROR   | [x] Array indentation error, expected 4 spaces but found 3
  97 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  97 | ERROR   | [x] Line indented incorrectly; expected at least 4 spaces, found 3
  97 | ERROR   | [x] Array indentation error, expected 4 spaces but found 3
  98 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
  98 | ERROR   | [x] Line indented incorrectly; expected at least 4 spaces, found 3
  98 | ERROR   | [x] Array indentation error, expected 4 spaces but found 3
  99 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
 101 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
 101 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 2
 102 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
 102 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 2
 103 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
 103 | ERROR   | [x] Line indented incorrectly; expected at least 4 spaces, found 3
 103 | ERROR   | [x] Array indentation error, expected 4 spaces but found 3
 104 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
 104 | ERROR   | [x] Line indented incorrectly; expected at least 4 spaces, found 3
 104 | ERROR   | [x] Array indentation error, expected 4 spaces but found 3
 105 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
 105 | ERROR   | [x] Line indented incorrectly; expected at least 4 spaces, found 3
 105 | ERROR   | [x] Array indentation error, expected 4 spaces but found 3
 106 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
 106 | ERROR   | [x] Line indented incorrectly; expected at least 4 spaces, found 3
 106 | ERROR   | [x] Array indentation error, expected 4 spaces but found 3
 107 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
 109 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
 109 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 2
 110 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
 110 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 2
 111 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
 111 | ERROR   | [x] Line indented incorrectly; expected at least 4 spaces, found 3
 111 | ERROR   | [x] Array indentation error, expected 4 spaces but found 3
 112 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
 112 | ERROR   | [x] Line indented incorrectly; expected at least 4 spaces, found 3
 112 | ERROR   | [x] Array indentation error, expected 4 spaces but found 3
 113 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
 113 | ERROR   | [x] Line indented incorrectly; expected at least 4 spaces, found 3
 113 | ERROR   | [x] Array indentation error, expected 4 spaces but found 3
 114 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
 114 | ERROR   | [x] Line indented incorrectly; expected at least 4 spaces, found 3
 114 | ERROR   | [x] Array indentation error, expected 4 spaces but found 3
 115 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
 117 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
 117 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 2
 118 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
 118 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 1
 120 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
 120 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 1
 121 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
 122 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
 123 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
 123 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 1
 124 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
 124 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 2
 126 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
 126 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 2
 127 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
 127 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 2
 129 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
 129 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 2
 130 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
 130 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 2
 131 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
 131 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 3
 132 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
 132 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 4
 132 | ERROR   | [x] Object operator not indented correctly; expected 5 spaces but found 4
 133 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
 133 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 4
 134 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
 134 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 2
 135 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
 135 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 1
 135 | ERROR   | [x] Expected 1 blank line after function; 0 found
 136 | ERROR   | [x] The closing brace for the class must have an empty line before it
--------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 230 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------


FILE: /animated_scroll_to/animated_scroll_to.permissions.yml
--------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------
 3 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------


FILE: /animated_scroll_to/animated_scroll_to.libraries.yml
------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------
 17 | ERROR | [x] Expected 1 newline at end of file; 0 found
------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------


FILE: /animated_scroll_to/animated_scroll_to.routing.yml
----------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------
 9 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------

Comment #5

avpaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

commented 1 March 2022 at 17:12

Status:

Needs review

» Needs work

Comment #6

ewout goosmann

Dutch

commented 2 March 2022 at 09:32

Hi @geoanders and @apaderno,

Thank you for reviewing this module.

I have committed the necessary changes.

Comment #7

ewout goosmann

Dutch

commented 2 March 2022 at 09:32

Status:

Needs work

» Needs review

Comment #8

geoanders commented 10 March 2022 at 22:31

Thanks! Coding standards issues seem to be resolved.

Comment #9

avpaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

commented 25 March 2022 at 17:46

Assigned:	Unassigned	» avpaderno
Status:	Needs review	» Fixed
Issue tags:	-PAreview: single application approval

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

Comment #10

ewout goosmann

Dutch

commented 28 March 2022 at 13:13

Thanks for reviewing my code again, for updating my account and for sharing the good reads for excellent maintainership!

Comment #11

11 April 2022 at 13:14

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

[D9] Animated Scroll To

Project link

Git instructions

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Comment #6

Comment #7

Comment #8

Comment #9

Comment #10

Comment #11

News items

Our community

Documentation

Drupal code base

Governance of community