Problem/Motivation

According to the return type documentation of Drupal\user\UserAuthInterface::authenticate:

@return int|bool
The user's uid on success, or FALSE on failure to authenticate.

Proposed resolution

Replace return NULL with return FALSE.

Issue fork mail_login-3266047

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

DieterHolvoet created an issue. See original summary.

DieterHolvoet opened merge request !2

dieterholvoet’s picture

dieterholvoet commented
Status: Active » Needs review
mqanneh’s picture

mqanneh
he/him
Primary language English
Location Amman
commented
Assigned: Unassigned » mqanneh

  • mqanneh committed 90b86b1 on 8.x-2.x authored by DieterHolvoet 
    Issue #3266047: AuthDecorator::authenticate is not supposed to return...
mqanneh’s picture

mqanneh
he/him
Primary language English
Location Amman
commented
Assigned: mqanneh » Unassigned
Status: Needs review » Fixed
mqanneh’s picture

mqanneh
he/him
Primary language English
Location Amman
commented
Status: Fixed » Closed (fixed)