Problem/Motivation

Just a minor code fix:
https://api.drupal.org/api/drupal/core!lib!Drupal!Core!Form!FormBase.php... doesn't contain a method "validatePath()", so I guess the inheritDoc is wrong?

It's just a custom helper function?

Steps to reproduce

Proposed resolution

Check, if my assumption is correct and fix phpdoc.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork page_manager-3265851

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Anybody created an issue. See original summary.

Anybody opened merge request !5

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Active » Needs review

Totally minor ;) We just discussed your code as we needed something similar in homebox module, so I found that.

Written in Gitlab IDE, so please check carefully.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

PS: If not used outside, perhaps change to "protected"? I didn't check if it can and should be used outside as helper function.

bluegeek9 made their first commit to this issue’s fork.

bluegeek9 changed the visibility of the branch 8.x-4.x to hidden.

bluegeek9’s picture

bluegeek9 commented
Category: Bug report » Task
Status: Needs review » Reviewed & tested by the community

The tests are failing unrelated to this change. The phpDoc is an improvement. FormBase does not provide a validatePath method to inherit the doc from.

joelpittet made their first commit to this issue’s fork.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Reviewed & tested by the community » Fixed

Thank you both, merged.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • joelpittet committed 2240e416 on 8.x-4.x authored by anybody 
    fix: #3265851 Wrong phpdoc for validatePath

By: anybody
By: bluegeek9
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

This commit added trailing whitespace to line 199, leading to the phpcs check failing. Would you like me to make a merge request for fixing it?

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

I assumed there lots of lint errors because we weren’t failing on them. Could you create a follow up to fail on linters and fix it there @liam Morland?

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Sorry if I did the mistake and didn't see it.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

#3584169: Fix issues raised by phpcs

It would have raised a warning for phpcs. In the follow-up, I set it to fail instead of warn on phpcs issues.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.