Unfork jQuery UI

All right here is a patch that use the vendor-update system to copy the source files to the assets/vendor/jquery-ui directory. essentially unforking the code.

This also takes care of updating the libraries.yml version whenever we update the jquery ui package.

+++ b/core/scripts/js/assets.js
@@ -180,6 +180,58 @@ const assetsFolder = `${coreFolder}/assets/vendor`;
+    // Add the jQuery UI source file, after the vendor-update command
+    // the `yarn build:jqueryui` command needs to be run manually.
+    {
+      pack: 'jquery-ui',
+      folder: 'jquery.ui',
+      files: [
+        'themes/base/autocomplete.css',
+        'themes/base/button.css',
+        'themes/base/checkboxradio.css',
+        'themes/base/controlgroup.css',
+        'themes/base/core.css',
+        'themes/base/dialog.css',
+        'themes/base/draggable.css',
+        'themes/base/images/ui-bg_flat_0_aaaaaa_40x100.png',
+        'themes/base/images/ui-icons_444444_256x240.png',
+        'themes/base/images/ui-icons_555555_256x240.png',
+        'themes/base/images/ui-icons_777620_256x240.png',
+        'themes/base/images/ui-icons_777777_256x240.png',
+        'themes/base/images/ui-icons_cc0000_256x240.png',
+        'themes/base/images/ui-icons_ffffff_256x240.png',
+        'themes/base/menu.css',
+        'themes/base/resizable.css',
+        'themes/base/theme.css',
+        'ui/data.js',
+        'ui/disable-selection.js',
+        'ui/focusable.js',
+        'ui/form-reset-mixin.js',
+        'ui/form.js',
+        'ui/ie.js',
+        'ui/jquery-patch.js',
+        'ui/keycode.js',
+        'ui/labels.js',
+        'ui/plugin.js',
+        'ui/position.js',
+        'ui/safe-active-element.js',
+        'ui/safe-blur.js',
+        'ui/scroll-parent.js',
+        'ui/tabbable.js',
+        'ui/unique-id.js',
+        'ui/version.js',
+        'ui/widget.js',
+        'ui/widgets/autocomplete.js',
+        'ui/widgets/button.js',
+        'ui/widgets/checkboxradio.js',
+        'ui/widgets/controlgroup.js',
+        'ui/widgets/dialog.js',
+        'ui/widgets/draggable.js',
+        'ui/widgets/menu.js',
+        'ui/widgets/mouse.js',
+        'ui/widgets/resizable.js'
+      ],

This is where the magic happens.

kinda different scope I'd say. Ideally we do this one after the other.

I want to remove the copy/paste of the source file so we keep only the minified versions of the JS files in the vendor/assets/jquery.ui folder

Sorry crosspost my reply was to xjm. Yes removing that was the plan

removing the comment was on purpose, it's not accurate anymore we don't aggregate the translations files :)

So here i'm using jquery 1.12.1 (unpatched!) to avoid having a huge diff in the patch.

Made some significant refactor to the vendor-update code, we can now define a callback that transforms a file content and file name during the copying. I don't want to add anymore features to this vendor-update thing because at some point it makes more sense to just use webpack or something.

This patch should be green. I'll add a few more patches with interdiffs to eventually remove all unminified files from the jquery.ui asset folder, adding a sourcemap to the files, removing the build:jqueryui command and commit checks.

was faster than expected. Latest code is 1.13.1 version with the build step removed, sourcemap info inlined, using vendor-upgrade

I would think that all the code review would happen on the jquery-ui repo/release notes. We don't review the changes to the source files in our repo for most of our other assets such as ckeditor*, js-cookie, pooperjs, shepherd, sortable, tabbable, etc.

Updated the code so that we have the source file, the minified file and a separate sourcemap to avoid bloating the minified file.

That was after a discussion with xjm. We don't have the source file for poperjs, etc. because they don't ship an unminified production version in their package. We have the unminified source for jquery, backbone, jquery form, jquery once, once. I guess the only other that jscookie and underscore would be libs we could also add the unminified source since they're available.

From what I understood, we're keeping the source for audit purposes during updates when we can, which is a different concern than having a map file available for debugging. Map files are not very suited for code audits during updates.

added a change notice

Thanks! just corrected the version number, it's 1.13.1