Problem/Motivation

There's constructor argument deprecation left in 2 classes after #2347783: Deprecate drupal_get_path() and drupal_get_filename() and replace with ExtensionList::getPath() and ExtensionList::getPathname()
It was forgotten in #3260806: Remove deprecated code from core/lib/Drupal/Core/Config

Proposed resolution

make $extension_path_resolver argument required and remove shim

Remaining tasks

review/commit

User interface changes

no

API changes

no

Data model changes

No

Release notes snippet

CommentFileSizeAuthor
#2 3265605-2.patch3.77 KBandypost
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

andypost created an issue. See original summary.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Issue summary: View changes
Status: Active » Needs review
FileSize
3265605-2.patch3.77 KB

patch

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
CreditAttribution: paulocs at CI&T commented
Status: Needs review » Reviewed & tested by the community

Patch #2 looks good.
It properly removes the deprecation in Drupal\Core\Config\ConfigInstaller and Drupal\Core\Config\ConfigManager.

Moving to RTBC.

  • catch committed d8bd62b on 10.0.x 
    Issue #3265605 by andypost, paulocs: Remove constructor argument shim...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed d8bd62b and pushed to 10.0.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.