file_create_url is deprecated in Drupal core 9.3 and will be removed in 10.0

CommentFileSizeAuthor
#4 interdiff_2-4.txt0 bytesvictoria-marina
#4 3265549-4.patch660 bytesvictoria-marina
#2 file_create_url_depcrecated-3265549-2.patch660 byteshmdnawaz

Issue fork colorbox-3265549

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

hmdnawaz created an issue. See original summary.

hmdnawaz’s picture

hmdnawaz commented
StatusFileSize
new file_create_url_depcrecated-3265549-2.patch660 bytes
victoria-marina’s picture

victoria-marina commented
Assigned: Unassigned » victoria-marina
Status: Active » Needs review

I'll review this.

victoria-marina’s picture

victoria-marina commented
Assigned: victoria-marina » Unassigned
StatusFileSize
new 3265549-4.patch660 bytes
new interdiff_2-4.txt0 bytes

The patch applies fine, its a RTBC for me.

victoria-marina’s picture

victoria-marina commented
victoria-marina’s picture

victoria-marina commented
Status: Needs review » Reviewed & tested by the community

paulmckibben’s picture

paulmckibben
he/him
Primary language English
Location Atlanta, GA
commented
Status: Reviewed & tested by the community » Fixed

@hmdnawaz, @victoria-marina, thank you both for creating and reviewing this patch.

paulmckibben’s picture

paulmckibben
he/him
Primary language English
Location Atlanta, GA
commented
Status: Fixed » Reviewed & tested by the community

Unfortunately, file_url_generator is only available in Drupal 9.3+. Since Drupal 9.2 is still supported, I must reverse this patch until Drupal 9.2 is no longer supported. See #3274802: file_url_generator is in Drupal 9.3+.

  • paulmckibben committed 7371a57 on 8.x-1.x 
    Revert "Issue #3265549 by victoria-marina, hmdnawaz: Remove deprecated...
paulmckibben’s picture

paulmckibben
he/him
Primary language English
Location Atlanta, GA
commented
Version: 8.x-1.x-dev » 2.0.x-dev

Moving this to the new 2.0.x branch for Drupal 10 compatibility fixes. Supports ^9.3 || ^10.

  • paulmckibben committed 7371a57 on 3265549-remove-deprecated-code 
    Revert "Issue #3265549 by victoria-marina, hmdnawaz: Remove deprecated...
  • paulmckibben committed 95165fe on 3265549-remove-deprecated-code authored by victoria-marina
    Issue #3265549 by victoria-marina, paulmckibben, hmdnawaz: Remove...
  • paulmckibben committed ee1428f on 3265549-remove-deprecated-code authored by hmdnawaz
    Issue #3265549 by victoria-marina, hmdnawaz: Remove deprecated code
paulmckibben’s picture

paulmckibben
he/him
Primary language English
Location Atlanta, GA
commented
Status: Reviewed & tested by the community » Fixed

paulmckibben opened merge request !21

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.