When browsing the project code base, I noticed that the repo does not have a contribute.md file. This file is a good addition because it provides useful links of resources on how to contribute to this project.

We are working on this as a group for the Discover Drupal project. We are learning markdown and the contribution workflow.

Because we are a mix of novices and first time contributors this may take a couple of weeks from start to finish.

PLEASE - We ask that this issue be reserved for the Discover Drupal graduates and mentors so we can work together as a group and become more comfortable with the process.

CommentFileSizeAuthor
#4 contributor-3264613-4.patch5.7 KBreenaraghavan

Issue fork smart_trim-3264613

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

volkswagenchick created an issue. See original summary.

alisonjo315 made their first commit to this issue’s fork.

alisonjo315 opened merge request !18

reenaraghavan’s picture

reenaraghavan commented
StatusFileSize
new contributor-3264613-4.patch5.7 KB

Added comments in contributor.md

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Version: 8.x-1.x-dev » 2.0.x-dev
Parent issue: » #3308526: [META] Provide advanced output handling / rewriting functionality
ultimike’s picture

ultimike
Primary language English
Location Florida, USA
commented
Parent issue: #3308526: [META] Provide advanced output handling / rewriting functionality »
markie’s picture

markie commented

Removing patch 4 as it has a lot of unnecessary file changes. Lets work in the feature branch.

rckstr_rohan made their first commit to this issue’s fork.

rohan-sinha’s picture

rohan-sinha commented
Status: Active » Needs review

Added a MR for the contribution.md file as per my understanding, suggestions are welcome, module looks good to be , will try to pick more issues, thanks.

sourabhjain made their first commit to this issue’s fork.

ultimike’s picture

ultimike
Primary language English
Location Florida, USA
commented
Status: Needs review » Needs work

Thanks, @rckstr_rohan - almost there. Please see my comments above.

-mike

rohan-sinha’s picture

rohan-sinha commented

hii @ultimike addressed the comments. thanks

rohan-sinha’s picture

rohan-sinha commented
Status: Needs work » Needs review
ultimike’s picture

ultimike
Primary language English
Location Florida, USA
commented
Status: Needs review » Needs work
rohan-sinha’s picture

rohan-sinha commented
Status: Needs work » Needs review
ultimike’s picture

ultimike
Primary language English
Location Florida, USA
commented

@rckstr_rohan I know I'm being picky about this file - I just want to make sure that is as good as it can be so that other contrib modules can follow our lead, know what I mean.

Thanks so much for sticking with this issue!

-mike

ultimike’s picture

ultimike
Primary language English
Location Florida, USA
commented
Status: Needs review » Needs work
rohan-sinha’s picture

rohan-sinha commented
Status: Needs work » Needs review

Hi @ultimike, sorry for late response, have taken your comments in consideration and have made some changes, please review.

  • ultimike committed eb13cae3 on 2.0.x 
    #3264613: Missing contributor file - finishing touches (for now).
ultimike’s picture

ultimike
Primary language English
Location Florida, USA
commented
Status: Needs review » Fixed

Thanks @rckstr_rohan for helping get this over the finish line. I made a few updates before committing it.

-mike

ultimike’s picture

ultimike
Primary language English
Location Florida, USA
commented

I failed to use the proper commit message, so giving credit here.

Sorry!
-mike

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.