Problem/Motivation

Previously we had to switch behat/mink-browserkit-driver for friends-of-behat/mink-browserkit-driver to get PHP 8 and Symfony 5 compatibility: #3209459: Switch to friends of behat MinkBrowserKitDriver for PHP 8 and Symfony 5 compatibility

Now, behat/mink does not yet have a release that is fully compatible with Symfony 6, but friends-of-behat/mink exists with a newer version which is compatible.

Steps to reproduce

Proposed resolution

Swap behat/mink for friends-of-behat/mink in 10.0.x.

Dependency evaluation

Maintainance

friends-of-behat has three active maintainers, one of whom is also a behat maintainer.

The project provides several behat plugins that aren't included in the main package, such as Symfony integration, which we don't use.

Additionally, friends-of-behat maintain 'friendly forks' of behat, which apply PRs for PHP 8/Symfony updates before they're available in the main branch, and also tag releases at a faster rate. They don't make any changes other than upstream compatibility fixes:

No updates other than Symfony compatibility will be provided, but this fork might be synchronised with the original repository in the future.

(from https://github.com/FriendsOfBehat/MinkExtension)

Security policy

None, this is a development dependency, but likely to get any security release that mink does.

Code quality

The same as mink with only minimal changes for upstream compatibility.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#5 3263841-5.patch9.91 KBlongwave
#3 3263841-3.patch8.22 KBlongwave

Comments

longwave created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Parent issue: » #3161889: [META] Symfony 6 compatibility
Related issues: +#3209459: Switch to friends of behat MinkBrowserKitDriver for PHP 8 and Symfony 5 compatibility
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review
StatusFileSize
new 3263841-3.patch8.22 KB

Status: Needs review » Needs work

The last submitted patch, 3: 3263841-3.patch, failed testing. View results

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs work » Needs review
StatusFileSize
new 3263841-5.patch9.91 KB
andypost’s picture

andypost
he/him
Primary language Russian
commented

So only behat/mink-selenium2-driver left from behat?

daffie’s picture

daffie commented
Status: Needs review » Needs work 
+++ b/composer.json
@@ -15,7 +15,7 @@
+        "friends-of-behat/mink": "^1.8",

Can we update it to version 1.10? See: https://github.com/FriendsOfBehat/Mink

murilohp’s picture

murilohp commented

Just a quick question here, behat/mink recently dropped the support for old PHP and SF versions, and made it compatible with SF 6.0, unfortunately this is just on master branch so they need to create a new release. I was wondering if we could create an issue upstream to check out if they could release a new version.

Ref: https://github.com/minkphp/Mink/commit/00bd80104cc3c4884cdd6164dee7fab7e...

If I'm saying something wrong here, so sorry, I just saw the commit and thought that I could help you out here.

andypost’s picture

andypost
he/him
Primary language Russian
commented

++ to #7 as there's 8.1 compatibility fix https://github.com/FriendsOfBehat/Mink/compare/v1.9.0...v1.10.0

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

I opened https://github.com/minkphp/Mink/issues/822 to see if behat/mink will make a release instead of having to switch to the fork.

murilohp’s picture

murilohp commented
Related issues: +#3252304: Implement elementAttributeNotExists in WebAssert.php
catch’s picture

catch
he/him
Primary language English
commented
Issue summary: View changes
andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue tags: +Needs reroll

@catch thanks for dependency evaluation)

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs work » Closed (duplicate)
Related issues: +#3252757: Update Drupal 10 to depend on Symfony 6.0, +#3264903: Switch from friends-of-behat/mink back to behat/mink once it's Symfony 6 compatible

This was committed in #3252757: Update Drupal 10 to depend on Symfony 6.0

#3264903: Switch from friends-of-behat/mink back to behat/mink once it's Symfony 6 compatible exists to revert if a new behat/mink is released in time.