Problem/Motivation

Nightwatch test files contained in modules are not linted. Currently there is a nightwatch tests in the ckeditor5 module that is not following core estlint rules: 

core/modules/ckeditor5/tests/src/Nightwatch/Tests/drupalHtmlBuilderTest.js

Steps to reproduce

Proposed resolution

update .eslintignore adding this rule: !modules/**/tests/src/Nightwatch/**/*.js

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#6 3263840-nr-bot.txt150 bytesneeds-review-queue-bot

Issue fork drupal-3263840

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nod_ created an issue. See original summary.

kmonahan made their first commit to this issue’s fork.

kmonahan opened merge request !2173

kmonahan’s picture

kmonahan commented

Opened https://git.drupalcode.org/project/drupal/-/merge_requests/2173 to unignore Nightwatch tests as suggested and to fix the linting errors in drupalHtmlBuilderTest.js.

kmonahan’s picture

kmonahan commented
Status: Active » Needs review
needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 3263840-nr-bot.txt150 bytes

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Version: 10.0.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

quietone’s picture

quietone commented
Status: Needs work » Closed (outdated)

I just tested and confirmed that core/modules/ckeditor5/tests/src/Nightwatch/Tests/drupalHtmlBuilderTest.js is linted.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

quietone closed merge request !2173