Changed logic in LocalTaxTypeBase::checkRegistrations() causes regressions with zones having multiple territories with inclusive postal codes

IMO, even though reverting the fix from the issue linked fixes the problem... That isn't where the problem lies.

I think the problem is coming from resolveZones() that affects this particular usecase, because of the following code:

 // Physical products use the origin zone, unless the store is
      // registered to pay taxes in the destination zone. This is required
      // when the total yearly transactions breach the defined threshold.
      // See http://www.vatlive.com/eu-vat-rules/vat-registration-threshold/
      $resolved_zones = $store_zones;
      $customer_zone = reset($customer_zones);
      if ($this->checkRegistrations($store, $customer_zone)) {
        $resolved_zones = $customer_zones;
      }

I think this part should be rewritten to call a different method that doesn't only check the country code.

The attached patch should hopefully fix your usecase.

I have a fix that seems to work, however if it is the right fix, it needs better comment... And perhaps the fix itself can be improved :)....

Same patch, with a coding standard fix.

Same patch in an attempt to make it more readable :p.

Last patch of the day...

Add additional test for Switzerland with German customers in Büsingen

-

@jsacksick here is a patch with the additional test we discussed on the EU VAT to check that DE VAT is not applied to a customer in Büsingen

@dwkitchen: We need to configure the Swiss VAT tax in the test if we want to make sure of that.

No, the test assumes that the Swiss Tax Type is not enabled.

This new test is testing EuTaxType line 300; that Büsingen is excluded from Germany

['country_code' => 'DE', 'excluded_postal_codes' => '27498, 78266'],

Committed! Thanks everyone!