Problem/Motivation

The hook_shortcut_default_set hook expects an user account as argument, but the hook declaration does not specify any type for the $account argument.

Steps to reproduce

N/A

Proposed resolution

Declare AccountInterface as $account argument type.

Remaining tasks

Review, test?, commit.

User interface changes

N/A

API changes

The described correction.

Data model changes

N/A

Release notes snippet

TBD.

CommentFileSizeAuthor
#2 3263201-2.patch1.02 KBmanuel.adan

Comments

manuel.adan created an issue. See original summary.

manuel.adan’s picture

manuel.adan
Location 🌌
commented
Assigned: manuel.adan » Unassigned
Status: Active » Needs review
StatusFileSize
new 3263201-2.patch1.02 KB
victoria-marina’s picture

victoria-marina commented
Assigned: Unassigned » victoria-marina

I'll review this.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Category: Bug report » Task
Issue tags: +Bug Smash Initiative
victoria-marina’s picture

victoria-marina commented
Assigned: victoria-marina » Unassigned
Status: Needs review » Reviewed & tested by the community

After the #2, the argument is now specified as an AccountInterface type argument, and everything works fine as far I can test. RTBC!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 3263201-2.patch, failed testing. View results

manuel.adan’s picture

manuel.adan
Location 🌌
commented
Status: Needs work » Reviewed & tested by the community

Backed to RTBC, automatic re-test doesn't seem related to the patch itself.

  • xjm committed 25abb4d on 10.0.x 
    Issue #3263201 by manuel.adan: Missing argument type on...

  • xjm committed a57fe2a on 9.4.x 
    Issue #3263201 by manuel.adan: Missing argument type on...

  • xjm committed 27b276f on 9.3.x 
    Issue #3263201 by manuel.adan: Missing argument type on...
xjm’s picture

xjm
she/her
Primary language English
commented
Version: 9.4.x-dev » 9.3.x-dev
Status: Reviewed & tested by the community » Fixed

@victoria-marina, this is a documentation-only patch so there's not really anything to test beyond verifying that the documentation is accurate and conforms to the coding standards, and that there are no other similar instances in the same API that should be fixed as part of the same issue scope. :)

I checked and verified that there aren't any other missing parameter types in the Shortcut API docs (this is actually the only hook in the file). The hook return value correctly has one.

Committed to 10.0.x, and cherry-picked to 9.4.x and 9.3.x as a patch-eligible documentation improvement.

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.