Remove drupal_required_modules() and mentions [#3262931]

Problem/Motivation

Follow-up to #3262805-14: Deprecate drupal_required_modules()

The function is deprecated for removal in 10.0.x

Proposed resolution

remove it with legacy test

Remaining tasks

review/commit

User interface changes

API changes

Data model changes

Release notes snippet

Comment	File	Size	Author
#3	interdiff-3262931-2-3.txt	295 bytes	voleger
#3	3262931-3.patch	2.86 KB	voleger
#3	10.0.x: PHP 8.1 & MySQL 5.7 29,032 pass PHP 8.1 & sqlite-3.27 29,032 pass
#2	3262931-2.patch	2.69 KB	andypost
#2	10.0.x: PHP 8.1 & MySQL 5.7 Custom Commands Failed

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

7 February 2022 at 15:39

andypost created an issue. See original summary.

Comment #2

andypost

he/him

Russian

CreditAttribution: andypost as a volunteer and at Skilld commented 7 February 2022 at 15:41

Status:

Active

» Needs review

File	Size
3262931-2.patch	2.69 KB
10.0.x: PHP 8.1 & MySQL 5.7 Custom Commands Failed

Comment #3

voleger

he/his

Ukrainian

Ukraine, Rivne

CreditAttribution: voleger as a volunteer and at GOLEMS GABB, Drupal Ukraine Community for Drupal Ukraine Community, GOLEMS GABB commented 7 February 2022 at 22:25

File	Size
3262931-3.patch	2.86 KB
10.0.x: PHP 8.1 & MySQL 5.7 29,032 pass PHP 8.1 & sqlite-3.27 29,032 pass
interdiff-3262931-2-3.txt	295 bytes

1 file was hidden/shown/deleted

File	Size
3262931-2.patch	2.69 KB
10.0.x: PHP 8.1 & MySQL 5.7 Custom Commands Failed

Comment #4

8 February 2022 at 00:02

Status:

Needs review

» Needs work

The last submitted patch, 3: 3262931-3.patch, failed testing. View results

Comment #5

andypost

he/him

Russian

CreditAttribution: andypost as a volunteer and at Skilld commented 8 February 2022 at 00:19

Status:

Needs work

» Reviewed & tested by the community

Unrelated test failure

Comment #6

8 February 2022 at 01:07

Status:

Reviewed & tested by the community

» Needs work

The last submitted patch, 3: 3262931-3.patch, failed testing. View results

Comment #7

andypost

he/him

Russian

CreditAttribution: andypost as a volunteer and at Skilld commented 8 February 2022 at 12:36

Status:

Needs work

» Reviewed & tested by the community

Retest went fine

Comment #8

8 February 2022 at 20:16

catch committed 4846745 on 10.0.x

Issue #3262931 by voleger, andypost: Remove drupal_required_modules()...

Comment #9

catch

he/him

English

CreditAttribution: catch at Third and Grove commented 8 February 2022 at 20:16

Status:

Reviewed & tested by the community

» Fixed

Wouldn't normally commit one function removal at a time, but since module.inc has already been cleared out once, there's not really a bigger scope to do this in.

Committed 4846745 and pushed to 10.0.x. Thanks!