Deprecate drupal_required_modules()

typo, needs work

Looks good. Single function usage was replaced with appropriate code. A deprecation message was added and is correct. The deprecation test is implemented.

Tests are failing.

+++ b/core/includes/install.inc
@@ -1138,9 +1140,16 @@ function install_profile_info($profile, $langcode = 'en') {
-    // drupal_required_modules() includes the current profile as a dependency.
-    // Remove that dependency, since a module cannot depend on itself.
-    $required = array_diff(drupal_required_modules(), [$profile]);
+    // Get a list of core's required modules.
+    $required = [];
+    $listing = new ExtensionDiscovery(\Drupal::root());
+    $files = $listing->scan('module');
+    foreach ($files as $name => $file) {
+      $info = $info_parser->parse($file->getPathname());
+      if (!empty($info) && !empty($info['required']) && $info['required']) {
+        $required[] = $name;
+      }
+    }

In scope of the foreach loop here, the $info variable has to be renamed to, let's say, $file_info variable

Made changes as per comment #8, Let's see if the test bot is happy or not.

By mistake added the wrong name of the patch...

Yes, that was the issue. Looks good now.

Looks good now, but needs a reroll.

Patch #10 applied cleanly over 9.4.x
Attaching the rerolled patch for 10.0.x

Committed e5c38d9 and pushed to 10.0.x. Thanks!

Yes, the patch #10 was not applied for 9.4.x branch

I added a 9.4.x test run.

#10 3262805-10.patch has to go into 9.4.x
#13 3262805-13-10.0.x.patch already committed into 10.0.x

Sorry folks of course this needs to go into 9.4.x too, committed the patch from #10 and pushed.